963511 - [Email] Vertically Center line and string

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Attachment: before and after.png

Hi Pavel,

Can you help implement this minor update?  When adding a new email account the "All done" screen's line and string are not vertically center.  They should be vertically centered between the header and buttons.  See the attached screen shot (the right is the correct alignment).  Thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Eric Pang [:epang] UX]

Attachment: Vertically centered.png

Hey Pavel, thanks for working on this, but now it looks like the div line is centered. Can we center using the text and div line?  See the attached, there should be 145px above and below.  Thanks!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Sure :) like this one?

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

It seems like the patch is changing one arbitrary-ish margin rem value to another arbitrary-ish value; should we be using calc() or flexbox or something to more confidently center things if that's the goal?  Especially if we have specific behaviour for when the string translates to something that takes up multiple lines.

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 8369225 [details]
After patch screenshot

looks good Pavel!  But can you look into Andrew's comments?  Thanks!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Andrew,

I agree with you :)

we will work on the Visual Design Refresh for v1.4 and v1.5 and I'm not sure if there will be some changes  of the confirm/modal dialogs and if 'yes' I will definitely do this with flex if 'no' we will need to plan some time to fix old [BB] ... but for now we don't have time to prepare this [BB] with flex or some other tricks. I think Eric can give us more light on this one.

Comment 8

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #7)
> Hey Andrew,
> 
> I agree with you :)
> 
> we will work on the Visual Design Refresh for v1.4 and v1.5 and I'm not sure
> if there will be some changes  of the confirm/modal dialogs and if 'yes' I
> will definitely do this with flex if 'no' we will need to plan some time to
> fix old [BB] ... but for now we don't have time to prepare this [BB] with
> flex or some other tricks. I think Eric can give us more light on this one.

Hey Guys, I believe there will be changes to the confirm/modal dialogs but I don't think they will be for v.1.4.

Comment 9

[BMO Automation]

Firefox OS is not being worked on