Closed
Bug 96353
Opened 23 years ago
Closed 23 years ago
Can not modify text styles from the format "Text Styles" submenu
Categories
(Core :: DOM: Editor, defect)
Tracking
()
mozilla0.9.4
People
(Reporter: TucsonTester1, Assigned: sfraser_bugs)
References
Details
Attachments
(1 file)
930 bytes,
patch
|
Details | Diff | Splinter Review |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.3+) Gecko/20010816 Netscape6/6.1b1 BuildID: 2001081608 When you try to modify the text in a document through format, text style, bold underline ect... It does not work. Reproducible: Always Steps to Reproduce:
Reporter | ||
Comment 1•23 years ago
|
||
Steps to reproduce.
Comment 3•23 years ago
|
||
this is a dup..definitely *going to find it*
Comment 5•23 years ago
|
||
No, this is not a dup of bug 83639. The problem here is that all of Text Styles commands are firing twice, so the attribute is set, then immediately unset by the 2nd command call. This is an important issue and should be fixed for 0.9.4
Assignee: brade → sfraser
Severity: normal → major
Summary: Can not modify text in the format tool bar. → Can not modify text styles from the format "Text Styles" submenu
Target Milestone: --- → mozilla0.9.4
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirmed under Mac/2001082208 on Mac OS 9.1. Styles chosen from Format/Text Styles on the menu bar momentarily take effect, but are almost instantaneously undone. Styles chosen from the Format Toolbar work properly.
Assignee | ||
Comment 8•23 years ago
|
||
This is happening because each <menuitem> observes the command node (and thus inherits its 'oncommand'), in addition to the parent <menupopup> having an oncommand(). So the command is handled by the <menuitem>, bubbles up to the < menupopup>, and is handled again. It's not clear to me why that <menupopup> needs the oncommand() at all.
Assignee: sfraser → cmanske
Assignee | ||
Comment 10•23 years ago
|
||
Comment 12•23 years ago
|
||
*** Bug 96372 has been marked as a duplicate of this bug. ***
Comment 13•23 years ago
|
||
Daniel supplied the same fix for the dup bug 97108, and that already has "a=", so let's let Daniel check in in. *** This bug has been marked as a duplicate of 97108 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Sorry, I worked on this bug at 4am this morning, jetlagging after a difficult way back from Seattle to Paris through London, and I just missed this current bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•