Closed
Bug 963539
Opened 11 years ago
Closed 11 years ago
bin/gaia-test shouldn't depend on nodejs-legacy in ubuntu
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: janx, Assigned: janx)
Details
Attachments
(1 file)
In Ubuntu, Node.js changed its binary name to `nodejs` in order not to conflict with the Amateur Packet Radio Node program: packages.ubuntu.com/node
bin/gaia-test still requires the binary name `node` used by the Ubuntu packge nodejs-legacy.
|
Assignee | |
Comment 1•11 years ago
|
||
Fixed bin/gaia-test to use the `nodejs` binary and fall back to `node` if not found.
Attachment #8365047 -
Flags: review?(bkelly)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8365047 [details] [review]
fix bin/gaia-test
Looks good. Thanks!
Attachment #8365047 -
Flags: review?(bkelly) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Ben Kelly [:bkelly] from comment #2)
> Comment on attachment 8365047 [details] [review]
> fix bin/gaia-test
>
> Looks good. Thanks!
Thanks! I'm not sure how to request checkin on this, can you please help?
Flags: needinfo?(bkelly)
|
|
||
Comment 4•11 years ago
|
||
Most people just have permissions to merge themselves. I think the checkin-needed keyword also works, although may be delayed.
I went ahead and merged the PR:
https://github.com/mozilla-b2g/gaia/commit/f382061fe95750d584a9078175c421a36892afc9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(bkelly)
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•11 years ago
|
||
Thanks a lot! I'll try to find out how to gain merge permissions.
You need to log in
before you can comment on or make changes to this bug.
Description
•