963607 - add some consts, make caches mutable members

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: GetChildAt: part1

not really like it but don't see how we can introduce consts for things that are supposed to be consts

Comment 1

[alexander :surkov (:asurkov)]

Attachment: GetChildAt: patch2

Comment 2

[alexander :surkov (:asurkov)]

Attachment: GetChildOffset patch1

Comment 3

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8365130 [details] [diff] [review]
GetChildOffset patch1

>-Accessible::GetIndexOf(Accessible* aChild)
>+Accessible::GetIndexOf(Accessible* aChild) const

const Accessible* ?

make it inline?

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 8365130 [details] [diff] [review]
GetChildOffset patch1

https://hg.mozilla.org/integration/mozilla-inbound/rev/15edf6b80226

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 8365130 [details] [diff] [review]
GetChildOffset patch1

https://hg.mozilla.org/integration/mozilla-inbound/rev/800f377f716e

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/15edf6b80226
https://hg.mozilla.org/mozilla-central/rev/800f377f716e