371 bytes, text/html
329 bytes, text/html
1.78 KB, patch
av (gone): review+
Marc Attinasi: superreview+
|Details | Diff | Splinter Review|
From Bugzilla Helper: User-Agent: Mozilla/4.76 [en]C-AOL (Win98; U) BuildID: 20010820 Mozilla/Netscape 6 will not render the opening page in the "shoot the rapids" game at www.warnerbros.com/ specifically at http://looneytunes.warnerbros.com/web/games/home.jsp after "click here" Reproducible: Always Steps to Reproduce: 1.go to http://looneytunes.warnerbros.com/web/games/home.jsp 2.watch "shoot the rapids" float by, and porky pig, then "click here" 3.click on "click here" and you will see a yellow/orange screen
The part that's not loading is embedded Flash This is the code: <embed TYPE="application/x-shockwave-flash" SRC=" /games/med/rapidsFinal.swf " WIDTH="506" HEIGHT="366" BGCOLOR="#FFCC00" QUALITY="HIGH" SWLIVECONNECT="FALSE" MENU="FALSE"></embed> Possible cause: leading space in src attribute, " /games/med/rapidsFinal.swf ".
Status: UNCONFIRMED → NEW
Ever confirmed: true
Peter, do you want to take this bug?
I think Andrei has a dup of this.
Assignee: kmcclusk → av
Component: Compositor → Plug-ins
QA Contact: petersen → shrir
No, this one looks different, if you mean the bug when we have no spaces between attributes. The present bug could be easy to fix -- we just need to trim leading and tailing spaces and tabs from the attributes.
Status: NEW → ASSIGNED
Yes, this would be a trivial fix. I think you can call nsAutoString.CompressWhitespace(). This may have to be done in a few places.
Andrei, can you review?
Assignee: av → peterlubczynski
Status: ASSIGNED → NEW
Keywords: patch, review
OS: Windows 98 → All
Priority: -- → P3
Hardware: PC → All
Whiteboard: [WHITESPACE] [seeking review]
Target Milestone: --- → mozilla0.9.5
Thanks to Andrei, I found that CompressWhitespace() is too eager to remove whitespace. It removes repeated whitepace INSIDE the string which is incorrect. Such a testcase would fail: <embed src=" /tmp/Many spaces in path.swf " type="application/x-shockwave-flash"> The new patch strips whitespace only from the begining and end. Please review.
Status: NEW → ASSIGNED
Comment on attachment 50965 [details] [diff] [review] slightly better patch This should be right. r=av
Attachment #50965 - Flags: review+
Comment on attachment 50965 [details] [diff] [review] slightly better patch sr=attinasi
Attachment #50965 - Flags: superreview+
Whiteboard: [WHITESPACE] [seeking review] → [WHITESPACE]
patch in trunk
Whiteboard: [WHITESPACE] → [WHITESPACE][patch in trunk]
pls check this in today, if you can.
Whiteboard: [WHITESPACE][patch in trunk] → [WHITESPACE][patch in trunk] [PDT+]
patch in branch, marking FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Whiteboard: [WHITESPACE][patch in trunk] [PDT+] → [WHITESPACE] [PDT+]
verif on all branch builds, test url is working now. (1001 builds). adding vtrunk.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.