within the warnerbros.com site, a game page will not render at all

VERIFIED FIXED in mozilla0.9.5

Status

()

Core
Plug-ins
P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: elaineking, Assigned: Peter Lubczynski)

Tracking

Trunk
mozilla0.9.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WHITESPACE] [PDT+], URL)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

17 years ago
From Bugzilla Helper:
User-Agent: Mozilla/4.76 [en]C-AOL  (Win98; U)
BuildID:    20010820

Mozilla/Netscape 6 will not render the opening page in the "shoot the rapids" 
game at www.warnerbros.com/ specifically at 
http://looneytunes.warnerbros.com/web/games/home.jsp after "click here"

Reproducible: Always
Steps to Reproduce:
1.go to http://looneytunes.warnerbros.com/web/games/home.jsp
2.watch "shoot the rapids" float by, and porky pig, then "click here"
3.click on "click here" and you will see a yellow/orange screen

Comment 1

17 years ago
The part that's not loading is embedded Flash

This is the code:
<embed TYPE="application/x-shockwave-flash" SRC=" /games/med/rapidsFinal.swf  "
WIDTH="506" HEIGHT="366" BGCOLOR="#FFCC00" QUALITY="HIGH" SWLIVECONNECT="FALSE"
MENU="FALSE"></embed>

Possible cause: leading space in src attribute, " /games/med/rapidsFinal.swf  ".


Comment 2

17 years ago
Confirming issue.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

17 years ago
Created attachment 50588 [details]
Embed element with original spaces in src path

Comment 4

17 years ago
Created attachment 50589 [details]
Spaces in the src removed, Flash object loads fine
Peter, do you want to take this bug?
(Assignee)

Comment 6

17 years ago
I think Andrei has a dup of this.
Assignee: kmcclusk → av
Component: Compositor → Plug-ins
QA Contact: petersen → shrir

Comment 7

17 years ago
No, this one looks different, if you mean the bug when we have no spaces between 
attributes. The present bug could be easy to fix -- we just need to trim leading 
and tailing spaces and tabs from the attributes.
Status: NEW → ASSIGNED
(Assignee)

Comment 8

17 years ago
Yes, this would be a trivial fix. I think you can call
nsAutoString.CompressWhitespace(). This may have to be done in a few places.
(Assignee)

Comment 9

17 years ago
Created attachment 50852 [details] [diff] [review]
simple patch to get rid of whitespace
(Assignee)

Comment 10

17 years ago
Andrei, can you review?
Assignee: av → peterlubczynski
Status: ASSIGNED → NEW
Keywords: patch, review
OS: Windows 98 → All
Priority: -- → P3
Hardware: PC → All
Whiteboard: [WHITESPACE] [seeking review]
Target Milestone: --- → mozilla0.9.5
(Assignee)

Updated

17 years ago
Attachment #50852 - Attachment is obsolete: true
(Assignee)

Comment 11

17 years ago
Created attachment 50965 [details] [diff] [review]
slightly better patch
(Assignee)

Comment 12

17 years ago
Thanks to Andrei, I found that CompressWhitespace() is too eager to remove
whitespace. It removes repeated whitepace INSIDE the string which is incorrect.
Such a testcase would fail:


<embed src="  /tmp/Many spaces   in   path.swf    "
type="application/x-shockwave-flash">

The new patch strips whitespace only from the begining and end. Please review.
Status: NEW → ASSIGNED

Comment 13

17 years ago
Comment on attachment 50965 [details] [diff] [review]
slightly better patch

This should be right. r=av
Attachment #50965 - Flags: review+

Comment 14

17 years ago
Comment on attachment 50965 [details] [diff] [review]
slightly better patch

sr=attinasi
Attachment #50965 - Flags: superreview+
(Assignee)

Updated

17 years ago
Whiteboard: [WHITESPACE] [seeking review] → [WHITESPACE]
(Assignee)

Comment 15

17 years ago
patch in trunk
Keywords: nsbranch+
Whiteboard: [WHITESPACE] → [WHITESPACE][patch in trunk]

Comment 16

17 years ago
pls check this in today, if you can.
Whiteboard: [WHITESPACE][patch in trunk] → [WHITESPACE][patch in trunk] [PDT+]
(Assignee)

Comment 17

17 years ago
patch in branch, marking FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Whiteboard: [WHITESPACE][patch in trunk] [PDT+] → [WHITESPACE] [PDT+]

Comment 18

17 years ago
verif on all branch builds, test url is working now. (1001 builds). adding 
vtrunk.
Status: RESOLVED → VERIFIED
Keywords: vtrunk
You need to log in before you can comment on or make changes to this bug.