Closed
Bug 963652
Opened 12 years ago
Closed 12 years ago
Handlify JS_ForwardGetPropertyTo
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
|
2.43 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Per bug 962256 comment 5, this shows up in profiles as being slower with exact rooting, because it is called from HTMLDocumentBinding::DOMProxyHandler::get. Maybe this will help.
I didn't handlify JS_GetPropertyById because that gets into a rats nest of needing to handlify AutoIdRooter, and I didn't really understand how to do that.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8365180 -
Flags: review?(terrence)
|
|
Assignee | |
Comment 2•12 years ago
|
||
I tested a little locally, but it doesn't really seem worth a try push given how simple it is...
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8365180 [details] [diff] [review]
Handlify JS_ForwardGetPropertyTo.
Review of attachment 8365180 [details] [diff] [review]:
-----------------------------------------------------------------
Great! Thanks for doing this! r=me
Attachment #8365180 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•