Closed Bug 963652 Opened 6 years ago Closed 6 years ago

Handlify JS_ForwardGetPropertyTo

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Per bug 962256 comment 5, this shows up in profiles as being slower with exact rooting, because it is called from HTMLDocumentBinding::DOMProxyHandler::get.  Maybe this will help.

I didn't handlify JS_GetPropertyById because that gets into a rats nest of needing to handlify AutoIdRooter, and I didn't really understand how to do that.
Attachment #8365180 - Flags: review?(terrence)
I tested a little locally, but it doesn't really seem worth a try push given how simple it is...
Comment on attachment 8365180 [details] [diff] [review]
Handlify JS_ForwardGetPropertyTo.

Review of attachment 8365180 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks for doing this! r=me
Attachment #8365180 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/8780eb781632
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.