96367 - [FIX]One radiobutton is now checked by default, also resets RBS when printing

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[Blake Ross]

In 2001082109, one radiobutton is now checked by default.  IE and 4.x don't do
this.  Was this deliberate?

Comment 1

[rods (gone)]

Yes, this is "Standard" or "Strict" behavior

http://www.w3.org/TR/html4/interact/forms.html#radio

But since IE doesn't check the first item I can turn this off.

Comment 2

[rods (gone)]

Oops, didn't mean to to makr fixed.

Comment 3

[rods (gone)]

Attachment: patch

Comment 4

[timeless]

r=timeless

Comment 5

[rods (gone)]

This bug is related to Bug 580002, now that we do standard mode the Radios get 
reset when the page is printed, this is very bad.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Wouldn't it be better to get the compatibility mode from aPresContext and leave
this behavior enabled in standard mode?

Comment 7

[Marc Attinasi]

I don't think we want to reset the radios when printing in any mode - is that
what the patch is fixing?

Comment 8

[Marc Attinasi]

Looks like there is no reason to auto-check one of the radios in either mode,
since there is no spec that says to do it and no browsers that do it. And I see
now that the printing safety check was just put in in case we ever decide TO
check one of the radios by default. sr=attinasi

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Why the addition of code within |#if 0|?

Comment 10

[rods (gone)]

The code inside the #if 0 fixes a major bug (related to Bug 58002).

So I am adding the fix now, so if the RFC ever becomes part of the spec we can 
just go in and turn this on and it will work.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

ok, a=dbaron on behalf of drivers

Comment 12

[rods (gone)]

*** Bug 90874 has been marked as a duplicate of this bug. ***

Comment 13

[rods (gone)]

fixed on branch and tip

Comment 14

[Blake Ross]

I still see the default selection in an 8/24 build.

Comment 15

[Kenneth Herron]

I'm also seeing this with the 2001082506 x86 Linux build.  The first radio
button is always preselected. For example, going to <http://www.hotornot.com/>,
the radio button for "1" is preselected.

Comment 16

[rods (gone)]

I checked in some code that I was using for debugging, not the actual fix. It is 
checked in now. 

fixed

Comment 17

[Madhur Bhatia]

verified fixed on build ID: 2001-08-29-11trunk - window2000.

The radiobutton does not have  a default selection in either of the modes.