963673 - [E.me] Attempting to add a "custom" smart collection does nothing

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[pfield]

Attachment: CustomSmartlog.txt

Description: 
If the user attempts to add a "custom" smart collection, nothing will happen. When naming 

Repro Steps:
1) Updated Buri to Build ID: 20140121004137.
2) Long press on the background until the prompt appears.
3) Select "add Smart Collections."
4) Attempt to add "Custom" smart collection.
 
Actual: 
Attempting to add a smart collection with "Custom" does not function.

Expected: 
Adding a smart collection with "custom" prompts the user to name a custom collection and then does so accordingly.

Environmental Variables
Device: Buri v 1.3.0 COM RIL
Build ID: 20140121004137
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/6f7dfe36ab6c
Gaia: 47049555282a9a01fb60d1e1421b57e2810c96f5
Platform Version: 28.0a2
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 5/5 

See attached: Video - logcat

Comment 1

[pfield]

Attachment: Customsmartcollection.mp4

There does not appear to be a way to add custom smart collections on 1.2, therefore this issue does not occur on Buri 1.2

Environmental Variables
Device: Buri v 1.2.0 COM RIL
Build ID: 20140121004053
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/c9f305c1d9a7
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: v1.2-device.cfg

Comment 2

[Jason Smith [:jsmith]]

I know this was working on an earlier 1.3 build.

Comment 3

[Cristian Rodriguez (:crdlc)]

Hi all, 

   Is this commit https://github.com/mozilla-b2g/gaia/commit/a15974a80d6b93a23054caaa5c8641c5e317db51 in your build? It looks like a problem with modal dialogs like bug 960659 thought

Thanks

Comment 4

[Cristian Rodriguez (:crdlc)]

Well, I was talking about v1.3, is collection feature available in v1.2? I think that it is not available there (I don't know if I am wrong)

Comment 5

[Cristian Rodriguez (:crdlc)]

OK, Ran forget my last comment 4, I got insane :)

My commit [1] (comment 3) is not available when you tested it. Please update your build and test again. Thanks a lot

[1] https://github.com/mozilla-b2g/gaia/commit/a15974a80d6b93a23054caaa5c8641c5e317db51

Comment 6

[Amir Nissim (:amirn)]

(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> Well, I was talking about v1.3, is collection feature available in v1.2? I
> think that it is not available there (I don't know if I am wrong)

Collections are new in v1.3 feature, not available in v1.2.

My guess is that Crisitian is right since the 'Custom Collection' feature uses a native prompt dialog:
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/CollectionsSuggest/CollectionsSuggest.js#L54

Comment 7

[Jason Smith [:jsmith]]

QA Wanted to retest on the latest 1.3 build.

Comment 8

[Peter Bylenga [:PBylenga]]

Issue does not reproduce on latest nightly v1.3, user is able to create a new custom Smart Collection as expected.

v1.3 Environmental Variables:
Device: buri v1.3 MOZ
BuildID: 20140127004002
Gaia: 25a45a836a4a21a30f63fa7b544b42e8b781180a
Gecko: c40099a42c1f
Version: 28.0a2
Firmware Version: v1.2-device.cfg

Comment 9

[Cristian Rodriguez (:crdlc)]

It was fixed in bug 960659

https://github.com/mozilla-b2g/gaia/commit/a15974a80d6b93a23054caaa5c8641c5e317db51