Closed Bug 963701 Opened 6 years ago Closed 6 years ago

Unscope the JSAutoCompartment in InitTargetObjects

Categories

(Core :: XBL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

Bobby pointed out that the auto compartment should cover the remainder of the method, or we're not really in any particular compartment for much of the function.  In practice, it doesn't matter, because InitClass does actually enter a compartment it self, but making it explicit is cleaner.
I've done a try run of this on L64 debug and it seems fine.
Attachment #8365241 - Flags: review?(bzbarsky)
Comment on attachment 8365241 [details] [diff] [review]
Unscope the JSAutoCompartment in InitTargetObjects. r=bz

r=me
Attachment #8365241 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/3664a7e8db93
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.