Closed
Bug 963701
Opened 12 years ago
Closed 12 years ago
Unscope the JSAutoCompartment in InitTargetObjects
Categories
(Core :: XBL, defect)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
|
1.68 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Bobby pointed out that the auto compartment should cover the remainder of the method, or we're not really in any particular compartment for much of the function. In practice, it doesn't matter, because InitClass does actually enter a compartment it self, but making it explicit is cleaner.
|
Assignee | |
Comment 1•12 years ago
|
||
I've done a try run of this on L64 debug and it seems fine.
Attachment #8365241 -
Flags: review?(bzbarsky)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8365241 [details] [diff] [review]
Unscope the JSAutoCompartment in InitTargetObjects. r=bz
r=me
Attachment #8365241 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•