Closed Bug 963739 Opened 8 years ago Closed 8 years ago

Minor styling improvements to the quick filter bar on OS X.

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 29.0

People

(Reporter: jsbruner, Assigned: jsbruner)

References

Details

Attachments

(5 files, 1 obsolete file)

The current bar has a couple issues we could improve:

1. It lacks a bottom border, which makes it very hard to tell when the bar ends.

2. There "appears" to be 2px of padding at the top, but only 1px at the bottom. This isn't actually true, since the padding is determined by the buttons, but we can fix this by making the margin-bottom 2px instead of 1.
Attached patch Fix. (obsolete) β€” β€” Splinter Review
This adds the border and changes the margin spacing. In addition, I removed the unused "#quick-filter-bar[filterActive="matches"]" selector.
Attachment #8365278 - Flags: ui-review?(richard.marti)
Attachment #8365278 - Flags: review?(richard.marti)
Attached image Old look. β€”
Attached image New look. β€”
These screenshots are for speeding up ui-review.
Comment on attachment 8365278 [details] [diff] [review]
Fix.

Review of attachment 8365278 [details] [diff] [review]:
-----------------------------------------------------------------

I'm minusing r and ui-r because of the issue when filtering tags.

::: mail/themes/osx/mail/quickFilterBar.css
@@ +56,5 @@
>    background-image: none;
>  }
>  
> +#quick-filter-bar-filter-text-bar {
> +  border-bottom: 1px solid rgb(190, 190, 190);

Please add the bottom border to quick-filter-bar-expando. When you filter by tags the border isn't shown. I'll attach a screenshot showing this.

Please use for the color #bebebe like for #quick-filter-bar-main-bar. Or change on #quick-filter-bar-main-bar to rgb(). Both colors are the same and for easier recognition it should be written in same format.
Attachment #8365278 - Flags: ui-review?(richard.marti)
Attachment #8365278 - Flags: ui-review-
Attachment #8365278 - Flags: review?(richard.marti)
Attachment #8365278 - Flags: review-
Attached image issue.png β€”
Screenshot shows only a half of quick-filter-bar-expando has a bottom border with filtering tags.
Attached patch Fix. β€” β€” Splinter Review
Ah, good catch!

Addressed the issue.
Attachment #8365278 - Attachment is obsolete: true
Attachment #8365318 - Flags: ui-review?(richard.marti)
Attachment #8365318 - Flags: review?(richard.marti)
Comment on attachment 8365318 [details] [diff] [review]
Fix.

Review of attachment 8365318 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8365318 - Flags: ui-review?(richard.marti)
Attachment #8365318 - Flags: ui-review+
Attachment #8365318 - Flags: review?(richard.marti)
Attachment #8365318 - Flags: review+
https://hg.mozilla.org/comm-central/rev/1bcfb3895555
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
(In reply to Josiah Bruner [:JosiahOne] from comment #0)
> The current bar has a couple issues we could improve:
> 
> 1. It lacks a bottom border, which makes it very hard to tell when the bar
> ends.

Now there are two borders if the input field is empty, it looks weird…
(In reply to SΓΆren Hentzschel from comment #9)
> Created attachment 8365530 [details]
> Bildschirmfoto 2014-01-25 um 15.10.14.png
> 
> (In reply to Josiah Bruner [:JosiahOne] from comment #0)
> > The current bar has a couple issues we could improve:
> > 
> > 1. It lacks a bottom border, which makes it very hard to tell when the bar
> > ends.
> 
> Now there are two borders if the input field is empty, it looks weird…

Thanks for finding that! I filed bug 963946 to fix those issues, and a fix should come within a day or two.
You need to log in before you can comment on or make changes to this bug.