963747 - Add the ability to request review from any of the suggested reviewers in one action

Status: NEW

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[(not currently active) Ted Mielczarek]

Often times people don't care who reviews their patch, simply that it gets review from a peer of the module in question. It would be nice if Bugzilla could facilitate this, by allowing you to request review from "a peer of module X" in some way. My ideal implementation of this would function something like:
1) User requests review from "peers@moduleX"
2) The review request shows up in review queries for all users in the group peers@moduleX, sends flag mail to all users in peers@moduleX.
3) When someone clears the r?peers@moduleX flag, the review is removed from review queries for all users in peers@moduleX.

dkl noted on IRC that a first approximation of this would be something like "expand r?peers@moduleX -> r?peer1 r?peer2 r?peer3 ...". This would be a decent half-step, but it'd require manually clearing the other requests after reviewing, and also make it unclear whether multiple reviews were desired or just a single review from any requestee.

Comment 1

[David Lawrence [:dkl]]

Probably best to work on this as an extension of our current Review extension on BMO and not necessarily upstream.

dkl

Comment 2

[:glob ✱]

by "peer" i'm going to assume you mean "suggested reviewers".  while strictly speaking these two aren't the same, we already a list of suggested reviewers and i think it's close enough to suit the requirements here.

> dkl noted on IRC that a first approximation of this would be something like
> "expand r?peers@moduleX -> r?peer1 r?peer2 r?peer3 ..."

i'm concerned that would cause more trouble than it fixes, and would like to echo ted's concerns surrounding the multiple review case.

Comment 3

[(not currently active) Ted Mielczarek]

Suggested reviewers would be fine.