If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Refactor TelemetryImpl::GetChromeHangs to never return a partial result

NEW
Unassigned

Status

()

Core
General
4 years ago
4 years ago

People

(Reporter: vladan, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
(In reply to Nathan Froyd (:froydnj) from comment #4)
> Comment on attachment 8362720 [details] [diff] [review]
> chromehangsUptime.patch
> 
> Review of attachment 8362720 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with a good answer for the HangMonitor.cpp bit.
> 
> ::: toolkit/components/telemetry/Telemetry.cpp
> @@ +1531,5 @@
> >    }
> >  
> > +  ok = JS_DefineProperty(cx, fullReportObj, "systemUptime",
> > +                         OBJECT_TO_JSVAL(systemUptimeArray),
> > +                         nullptr, nullptr, JSPROP_ENUMERATE);
> 
> Can you file a followup for inverting the order that we do things in this
> function, so that we:
> 
> - build the arrays;
> - set fullReportObj properties;
> - set *ret.
> 
> in that order?  We've tried to not leave partial bits hanging around on
> failure in other reports; it'd be good to follow the same pattern here.
(Reporter)

Updated

4 years ago
Component: General → General
Product: Chat Core → Core
Version: trunk → Trunk
You need to log in before you can comment on or make changes to this bug.