96381 - MLK: Memory leak of 184 bytes from 1 block allocated in nsSocketTransportService::CreateTransportOfTypes(UINT,char const* *,char const*,int,char const*,int,UINT,UINT,nsITransport * *)

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2001-08-21-09, Windows 2000, using Purify

MLK: Memory leak of 184 bytes from 1 block allocated in
nsSocketTransportService::CreateTransportOfTypes(UINT,char const* *,char
const*,int,char const*,int,UINT,UINT,nsITransport * *)
        Distribution of leaked blocks
               184 bytes from 1 block of 184 bytes (0x0ee42218) 
        Allocation location
            new(UINT)+0xc        [C:\WINNT\SYSTEM32\msvcrt.DLL ip=0x580039cb]
            nsSocketTransportService::CreateTransportOfTypes(UINT,char const*
*,char const*,int,char const*,int,UINT,UINT,nsITransport * *)+0x175
[c:\moz_src\mozilla\netwerk\base\src\nsSocketTransportService.cpp:586 ip=0x04587e58]
            nsSocketTransportService::CreateTransportOfType(char const*,char
const*,int,char const*,int,UINT,UINT,nsITransport * *)+0x7a
[c:\moz_src\mozilla\netwerk\base\src\nsSocketTransportService.cpp:554 ip=0x04587cd3]
            nsMsgProtocol::OpenNetworkSocketWithInfo(char const*,int,char
const*,nsIInterfaceRequestor *)+0x1c7
[c:\moz_src\mozilla\mailnews\base\util\nsMsgProtocol.cpp:113 ip=0x083e3a7a]
            nsMsgProtocol::OpenNetworkSocket(nsIURI *,char
const*,nsIInterfaceRequestor *)+0x181
[c:\moz_src\mozilla\mailnews\base\util\nsMsgProtocol.cpp:134 ip=0x083e3cbc]
            nsNNTPProtocol::Initialize(nsIURI *,nsIMsgWindow *)+0xbea
[c:\moz_src\mozilla\mailnews\news\src\nsNNTPProtocol.cpp:529 ip=0x08d50b3b]
            nsNntpService::RunNewsUrl(nsIURI *,nsIMsgWindow *,nsISupports
*)+0xd8 [c:\moz_src\mozilla\mailnews\news\src\nsNntpService.cpp:1129 ip=0x08d29a57]
            nsNntpService::UpdateCounts(nsINntpIncomingServer *,nsIMsgWindow
*)+0x286 [c:\moz_src\mozilla\mailnews\news\src\nsNntpService.cpp:1483 ip=0x08d2b7f2]
            nsNntpIncomingServer::PerformExpand(nsIMsgWindow *)+0x190
[c:\moz_src\mozilla\mailnews\news\src\nsNntpIncomingServer.cpp:592 ip=0x08d32e78]
            XPTC_InvokeByIndex+0x75
[c:\moz_src\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp:137
ip=0x100d1ac4]

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Darin, do you have any ideas for this, or might it be an outright DUP of a bug 
already logged?

Comment 2

[Darin Fisher]

based on the size and point of allocation, it's probably a nsSocketTransport
that is leaking.  i don't know of any similar reports.  any idea how long this
leak has been with us?

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Sorry, unfortunately I don't.  Seth might, or Suresh might, though.  I just ran
this last night.

Comment 4

[David :Bienvenu]

yes, it's an nsSocketTransport that's leaking. I'll look at this while I look at
other leaks.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Attachment: 'Stack'

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

I got this leak by simply starting mailnews and opening n.p.m.macosx for the 
1st time (said I had 783 new headers, but it downloaded 758, known bug).

I had another newsgroup on the news.mozilla.org server, but the only 
interaction with that was the "checking newsgroup 1 of 2 for new messages" 
routine we have automatically.

Comment 7

[David :Bienvenu]

I don't see this anymore - I think it's fixed by closing the socket immediately
after sending the logout/quit.

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

I don't see this any longer, either, using the same testcase as above, with a 
current trunk build on Windows 2000.