963845 - Discuss new manifest (package.json, config.json|jetpack-test-options.json)

Status: RESOLVED INVALID

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: https://github.com/mozilla/addon-sdk/pull/1363

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

Just getting this off of my queue, only f- because it's not clear what to do about the `verbose`, `check_memory`, etc flags atm

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

Great analysis, will defer to Irakli on the fine details.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

Looks good to me, for whatever that's worth.

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

I'm a bit concerned about aliases; overall looks promising!

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

I have added few notes, but in general I like this!

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

With jpm, this is no longer needed