Closed Bug 963845 Opened 8 years ago Closed 7 years ago

Discuss new manifest (package.json, config.json|jetpack-test-options.json)

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8365409 - Flags: feedback?(zer0)
Attachment #8365409 - Flags: feedback?(rFobic)
Attachment #8365409 - Flags: feedback?(kwierso)
Attachment #8365409 - Flags: feedback?(jgriffiths)
Attachment #8365409 - Flags: feedback?(evold)
Attachment #8365409 - Flags: feedback?(dtownsend+bugmail)
Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

Just getting this off of my queue, only f- because it's not clear what to do about the `verbose`, `check_memory`, etc flags atm
Attachment #8365409 - Flags: feedback?(evold) → feedback-
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

Great analysis, will defer to Irakli on the fine details.
Attachment #8365409 - Flags: feedback?(jgriffiths) → feedback+
Attachment #8365409 - Flags: feedback?(dtownsend+bugmail) → feedback-
Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

Looks good to me, for whatever that's worth.
Attachment #8365409 - Flags: feedback?(kwierso) → feedback+
Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

I'm a bit concerned about aliases; overall looks promising!
Attachment #8365409 - Flags: feedback+ → feedback-
Attachment #8365409 - Flags: feedback?(zer0) → feedback-
Comment on attachment 8365409 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1363

I have added few notes, but in general I like this!
Attachment #8365409 - Flags: feedback?(rFobic) → feedback+
With jpm, this is no longer needed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.