96385 - nsChromeRegistry::ConvertChromeURL does GetInstallRoot a bunch of times

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Simon Fraser [no longer active]]

On startup, nsChromeRegistry::ConvertChromeURL calls
  rv = GetInstallRoot(mInstallRoot); 
a whole bunch of times, because we haven't got a profile yet. This does directory 
and nsIFile stuff that isn't exactly cheap; it seems that we could cache 
mInstallRoot until the state of 'mProfileInitialized' changes.

Comment 1

[David Hyatt]

Actually I think that code is just legacy and can be removed.  ccarlen long ago 
hooked up the chrome registry to get a callback when the profile gets picked, 
so ConvertChromeURL doesn't need to have any of that code any more.

Comment 2

[David Hyatt]

Hmmm, somebody came along and fixed this.  Thanks to my anonymous benefactor!

Comment 3

[Brendan Eich [:brendan]]

I think dp was that anonymous benefactor...

/be

Comment 4

[Suresh Duddi (gone)]

I would have loved to, but it wasnt me. It was conrad.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/rdf/chrome/src&command=DIFF_FRAMESET&file=nsChromeRegistry.cpp&rev2=1.211&rev1=1.210

Comment 5

[John Morrison]

So is the one remaining place where we call GetInstallRoot() still required,
or can this all be removed.
 http://lxr.mozilla.org/mozilla/source/rdf/chrome/src/nsChromeRegistry.cpp#2864