browser_946320_tabs_from_other_computers.js test fails with Fxa enabled.

RESOLVED FIXED in Firefox 29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: markh, Assigned: ttaubert)

Tracking

Trunk
Firefox 29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The test browser_946320_tabs_from_other_computers.js checks that after simulating a user being signed into Sync, the relevant sync menu items appears.  This user simulation isn't suitable for Firefox Accounts, and thus the test fails.  We'll need to fix this before we can enable Fxa by default.
Whiteboard: [qa?]

Comment 1

5 years ago
(In reply to Mark Hammond [:markh] from comment #0)
> The test browser_946320_tabs_from_other_computers.js checks that after
> simulating a user being signed into Sync, the relevant sync menu items
> appears.  This user simulation isn't suitable for Firefox Accounts, and thus
> the test fails.  We'll need to fix this before we can enable Fxa by default.

What exactly goes wrong in fxa? Do you have a try run that demonstrates the problem? There are various sync tests that use a similar pattern...
(Assignee)

Updated

5 years ago
Assignee: nobody → ttaubert
Blocks: 964922
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 8368320 [details] [diff] [review]
0002-Bug-963865-Fix-browser_946320_tabs_from_other_comput.patch
Attachment #8368320 - Flags: review?(mhammond)
(Reporter)

Comment 3

5 years ago
Comment on attachment 8368320 [details] [diff] [review]
0002-Bug-963865-Fix-browser_946320_tabs_from_other_comput.patch

Review of attachment 8368320 [details] [diff] [review]:
-----------------------------------------------------------------

One day we should invent a testing .jsm that the xpcshell tests can share with the b-c tests, but not this day!
Attachment #8368320 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/mozilla-central/rev/08d8f9e97fdd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.