964061 - Convert CRMFObject to WebIDL bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Part 1: Convert CRMFObject to WebIDL bindings; r=bzbarsky

Comment 2

[(no longer active)]

Attachment: Part 2: Remove nsIDOMCRMFObject; r=bzbarsky

Comment 3

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=b59c9f1fa542

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8365675 [details] [diff] [review]
Part 1: Convert CRMFObject to WebIDL bindings; r=bzbarsky

>+++ b/dom/webidl/CRMFObject.webidl

How about just making this entire webidl file conditional on that ifdef (in dom/bindings/moz.build) instead of making it preprocessed?  Seems cleaner to me...

Would need to make the #include in nsCrypto.cpp conditional, of course.

Also, might be worth making this interface [NoInterfaceObject] and nuking it from test_interfaces.html.

r=me with that

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8365676 [details] [diff] [review]
Part 2: Remove nsIDOMCRMFObject; r=bzbarsky

Do we need to inherit from nsISupports at all, or can we switch to inline refcounting and no nsISupports?  Or even to an owned object?

r=me either way

Comment 6

[(no longer active)]

I'll address all of the comments when landing.  I made CRMFObject owned, and got rid of the nsISupports inheritance.

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cea61b9730f
https://hg.mozilla.org/integration/mozilla-inbound/rev/e50f0e1b8dcc

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cea61b9730f
https://hg.mozilla.org/mozilla-central/rev/e50f0e1b8dcc