Closed Bug 964061 Opened 6 years ago Closed 6 years ago
Convert CRMFObject to Web
No description provided.
Comment on attachment 8365675 [details] [diff] [review] Part 1: Convert CRMFObject to WebIDL bindings; r=bzbarsky >+++ b/dom/webidl/CRMFObject.webidl How about just making this entire webidl file conditional on that ifdef (in dom/bindings/moz.build) instead of making it preprocessed? Seems cleaner to me... Would need to make the #include in nsCrypto.cpp conditional, of course. Also, might be worth making this interface [NoInterfaceObject] and nuking it from test_interfaces.html. r=me with that
Attachment #8365675 - Flags: review?(bzbarsky) → review+
Comment on attachment 8365676 [details] [diff] [review] Part 2: Remove nsIDOMCRMFObject; r=bzbarsky Do we need to inherit from nsISupports at all, or can we switch to inline refcounting and no nsISupports? Or even to an owned object? r=me either way
Attachment #8365676 - Flags: review?(bzbarsky) → review+
I'll address all of the comments when landing. I made CRMFObject owned, and got rid of the nsISupports inheritance.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.