Closed
Bug 964061
Opened 12 years ago
Closed 12 years ago
Convert CRMFObject to WebIDL bindings
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(2 files)
|
16.78 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
5.38 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Comment 1•12 years ago
|
||
| Assignee | ||
Comment 2•12 years ago
|
||
| Assignee | ||
Updated•12 years ago
|
Attachment #8365675 -
Flags: review?(bzbarsky)
| Assignee | ||
Updated•12 years ago
|
Attachment #8365676 -
Flags: review?(bzbarsky)
| Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8365675 [details] [diff] [review]
Part 1: Convert CRMFObject to WebIDL bindings; r=bzbarsky
>+++ b/dom/webidl/CRMFObject.webidl
How about just making this entire webidl file conditional on that ifdef (in dom/bindings/moz.build) instead of making it preprocessed? Seems cleaner to me...
Would need to make the #include in nsCrypto.cpp conditional, of course.
Also, might be worth making this interface [NoInterfaceObject] and nuking it from test_interfaces.html.
r=me with that
Attachment #8365675 -
Flags: review?(bzbarsky) → review+
Comment 5•12 years ago
|
||
Comment on attachment 8365676 [details] [diff] [review]
Part 2: Remove nsIDOMCRMFObject; r=bzbarsky
Do we need to inherit from nsISupports at all, or can we switch to inline refcounting and no nsISupports? Or even to an owned object?
r=me either way
Attachment #8365676 -
Flags: review?(bzbarsky) → review+
| Assignee | ||
Comment 6•12 years ago
|
||
I'll address all of the comments when landing. I made CRMFObject owned, and got rid of the nsISupports inheritance.
| Assignee | ||
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1cea61b9730f
https://hg.mozilla.org/mozilla-central/rev/e50f0e1b8dcc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•12 years ago
|
Whiteboard: [qa-]
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•