Closed Bug 964061 Opened 6 years ago Closed 6 years ago

Convert CRMFObject to WebIDL bindings

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [qa-])

Attachments

(2 files)

No description provided.
Attachment #8365675 - Flags: review?(bzbarsky)
Attachment #8365676 - Flags: review?(bzbarsky)
Comment on attachment 8365675 [details] [diff] [review]
Part 1: Convert CRMFObject to WebIDL bindings; r=bzbarsky

>+++ b/dom/webidl/CRMFObject.webidl

How about just making this entire webidl file conditional on that ifdef (in dom/bindings/moz.build) instead of making it preprocessed?  Seems cleaner to me...

Would need to make the #include in nsCrypto.cpp conditional, of course.

Also, might be worth making this interface [NoInterfaceObject] and nuking it from test_interfaces.html.

r=me with that
Attachment #8365675 - Flags: review?(bzbarsky) → review+
Comment on attachment 8365676 [details] [diff] [review]
Part 2: Remove nsIDOMCRMFObject; r=bzbarsky

Do we need to inherit from nsISupports at all, or can we switch to inline refcounting and no nsISupports?  Or even to an owned object?

r=me either way
Attachment #8365676 - Flags: review?(bzbarsky) → review+
I'll address all of the comments when landing.  I made CRMFObject owned, and got rid of the nsISupports inheritance.
https://hg.mozilla.org/mozilla-central/rev/1cea61b9730f
https://hg.mozilla.org/mozilla-central/rev/e50f0e1b8dcc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.