ShortcutUtils.jsm should capitalize shortcut keys

RESOLVED FIXED in mozilla29

Status

()

Toolkit
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

unspecified
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Right now, if the shortcut key is defined as lowercase, we return it as such. Convention in every OS we ship on is uppercase. The module should probably deal with that itself. Patch coming up soon.

NB: slight worry: what does .toUpperCase() do for e.g. non-Latin-based scripts, and what is convention there?
Created attachment 8365679 [details] [diff] [review]
shortcuts should always be uppercase,

Random spot-check seems to indicate this should generally produce the desired result. However, see also: http://stackoverflow.com/questions/19286435/javascript-touppercase-mess-up-in-chrome-for-latin-character . An alternative solution would be WONTFIX, and making l10n teams update their strings to uppercase where required.
Attachment #8365679 - Flags: review?(bmcbride)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #8365679 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/227a757e0c77
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.