Closed
Bug 964072
Opened 10 years ago
Closed 10 years ago
Add ids to some preferences dialog elements
Categories
(Thunderbird :: Preferences, defect)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: alta88, Assigned: alta88)
Details
Attachments
(1 file, 1 obsolete file)
6.62 KB,
patch
|
alta88
:
review+
|
Details | Diff | Splinter Review |
Otherwise, adding tabs/tabpanels is difficult and selecting tabs externally doesn't work.
Assignee: nobody → alta88
Attachment #8365689 -
Flags: review?(richard.marti)
Comment 2•10 years ago
|
||
Comment on attachment 8365689 [details] [diff] [review] prefsDialog.patch Review of attachment 8365689 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. But bonus points if you add the ids also to the tabs without them ;). ::: mail/components/preferences/advanced.xul @@ +151,5 @@ > <tab id="generalTab" label="&itemGeneral.label;"/> > <tab label="&itemDisplay.label;"/> > <tab id="networkingTab" label="&itemNetworking.label;"/> > <tab label="&itemUpdate.label;"/> > <tab label="&itemCertificates.label;"/> When you are on adding ids, wouldn't you do that also to the tabs?
Attachment #8365689 -
Flags: review?(richard.marti) → review+
sure.
Attachment #8365689 -
Attachment is obsolete: true
Attachment #8365711 -
Flags: review+
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/eff977c91041
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•