Closed Bug 964095 Opened 10 years ago Closed 10 years ago

DEVICE_DEBUG should set adb and devtools

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review 
Currently it sets debugger.remote-mode = 'adb-devtools', which does not allow the app manager to connect to the device. We need to set adb-devtools instead.
Attached file Github pull request — 

        Attachment #8365714 -
        Flags: review?(yurenju.mozilla)

        Attachment #8365714 -
        Flags: review?(fabrice)

    
    

    
  
Comment on attachment 8365714 [details] [review]
Github pull request

Kevin, r=yurenju if you modify build/test/integration/build.test.js:139 to adb-devtools

        Attachment #8365714 -
        Flags: review?(yurenju.mozilla) → review+

    
    

    
  
Comment on attachment 8365714 [details] [review]
Github pull request

Fabrice - moving you to feedback? in case you have any comments before/after this lands.

        Attachment #8365714 -
        Flags: review?(fabrice) → feedback?(fabrice)

    
    

    
  
Got green travis, and landed in master: https://github.com/mozilla-b2g/gaia/commit/6586d2b8b43c6997be5cf5895bbdf3dd20490725
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

        Attachment #8365714 -
        Flags: feedback?(fabrice)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: