Digest::SHA 5.82 and newer always croak on wide characters, preventing saved searched from being displayed

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
Query/Bug List
--
major
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

({regression})

4.4.1
Bugzilla 4.4
regression
Bug Flags:
approval +
approval4.4 +
blocking4.4.2 +

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Digest::SHA no longer accepts Unicode characters since 5.82, preventing saved searches from being displayed if their name contains such characters. The fix I implemented in bug 477513 has been reverted in bug 767623 in 4.4 because at that time it was fine to pass Unicode characters (5.82 wasn't released yet). This fix must come back.
Flags: blocking4.4.2+
(Assignee)

Comment 1

4 years ago
Created attachment 8365738 [details] [diff] [review]
patch, v1

Must land before we release 4.4.2.
Attachment #8365738 - Flags: review?(justdave)
Attachment #8365738 - Flags: review?(dkl)
(Assignee)

Comment 2

4 years ago
I did some testing, and my patch restores exactly the old behavior, i.e. passing the same Unicode string returns exactly the same key as before 5.82. So "old" tokens won't be invalidated by this patch, which is good. :)
Comment on attachment 8365738 [details] [diff] [review]
patch, v1

r=dkl
Attachment #8365738 - Flags: review?(dkl) → review+

Updated

4 years ago
Flags: approval?
Flags: approval4.4?
(Assignee)

Updated

4 years ago
Attachment #8365738 - Flags: review?(justdave)
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
(Assignee)

Comment 4

4 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Token.pm
modified template/en/default/pages/release-notes.html.tmpl
Committed revision 8894.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Token.pm
modified template/en/default/pages/release-notes.html.tmpl
Committed revision 8652.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.