Closed Bug 964153 Opened 6 years ago Closed 6 years ago

Only WidgetTouchEvent copies the strong reference to widget at duplicating private event data

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file, 1 obsolete file)

Only WidgetTouchEvent copies WidgetGUIEvent::widget at duplicating private event data. It occurs at nsDOMEvent::DuplicatePrivateData() called.

I guess that it's just a bug since it uses copy constructor like constructor without any additional code.

The change is by Wes Johnston at bug 741666.

Wes Johnston:

Did you copy the widget intentionally?
Flags: needinfo?(wjohnston)
I don't think this was intentional on my part.
Flags: needinfo?(wjohnston)
Attached patch Patch (obsolete) — Splinter Review
Thank you.

I think that we shouldn't copy it.

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=1e70b2cb007b
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Attachment #8369991 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/cfcebde86f40
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.