Remove the GB2312 and GBK decoders

RESOLVED FIXED in mozilla35

Status

()

defect
P4
trivial
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

unspecified
mozilla35
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

6 years ago
If bug 959058 sticks in the tree to release, remove the GB2312 and GBK decoders that became dead code.

Updated

6 years ago
Priority: -- → P4
Assignee

Comment 1

6 years ago
When fixing this, also remove the strings gbk, gbk.key and gb18030  from charsetMenu.properties.
Assignee

Updated

5 years ago
Status: NEW → ASSIGNED
QA Contact: hsivonen
Assignee

Updated

5 years ago
QA Contact: hsivonen
Assignee

Updated

5 years ago
Attachment #8493646 - Flags: review?(VYV03354)
Attachment #8493646 - Flags: review?(VYV03354) → review+
Assignee

Comment 5

5 years ago
Posted patch Adjust gfxSplinter Review
Oops. I failed to update the gfx code for processing legacy Mac Chinese font names and running only linux64 builds on try didn't catch that. Here's an addendum to do that.
https://tbpl.mozilla.org/?tree=Try&rev=a2c56adf562c

Note that names in WAP code and nsSearchService go through label-to-encoding handling, so it's not critical to update those, and those have more no-longer-canonical names around than just GB2312. I'll file bugs to update those.
Attachment #8496756 - Flags: review?(VYV03354)
Attachment #8496756 - Flags: review?(VYV03354) → review+
https://hg.mozilla.org/mozilla-central/rev/e538372b2413
https://hg.mozilla.org/mozilla-central/rev/529d26ff3f59
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Depends on: 1089787
No longer depends on: 1089787
Blocks: 1174580
You need to log in before you can comment on or make changes to this bug.