964261 - Declare a widget to events created by TabParent::InjectTouchEvent

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Kats, I forgot to set the widget for the event. As a result it returns some weird result when we try to tap as the the coordinates hits: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#1503

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: widget.sendtouchevent.patch

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: widget.sendtouchevent.patch

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8365963 [details] [diff] [review]
widget.sendtouchevent.patch

Review of attachment 8365963 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/TabParent.cpp
@@ +1933,5 @@
>                                    aRotationAngles[i],
>                                    aForces[i]);
> +
> +    if (msg == NS_TOUCH_END || msg == NS_TOUCH_CANCEL) {
> +      t->mChanged = true;

Why this? Please add a comment explaining why this is needed.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: widget.sendtouchevent.patch

Does the comment help ?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8366274 [details] [diff] [review]
widget.sendtouchevent.patch

Review of attachment 8366274 [details] [diff] [review]:
-----------------------------------------------------------------

It helps a bit. It doesn't fully explain why we want to treat all injected touch events as changed, but I guess that's a reasonable decision given that we're not tracking which touches are actually changing between calls to injectTouchEvent.

::: dom/ipc/TabParent.cpp
@@ +1934,5 @@
>                                    aForces[i]);
> +
> +    // Consider all injected touch events as changedTouches. For more details
> +    // about the meaning of changedTouches for each event, see
> +    // https://developer.mozilla.org/fr/docs/Web/API/TouchEvent.changedTouches

Remove the "fr/" from the URL here since that sends it to the french-locale page.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> Comment on attachment 8366274 [details] [diff] [review]
> widget.sendtouchevent.patch
> 
> Review of attachment 8366274 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It helps a bit. It doesn't fully explain why we want to treat all injected
> touch events as changed, but I guess that's a reasonable decision given that
> we're not tracking which touches are actually changing between calls to
> injectTouchEvent.
> 
> ::: dom/ipc/TabParent.cpp
> @@ +1934,5 @@
> >                                    aForces[i]);
> > +
> > +    // Consider all injected touch events as changedTouches. For more details
> > +    // about the meaning of changedTouches for each event, see
> > +    // https://developer.mozilla.org/fr/docs/Web/API/TouchEvent.changedTouches
> 
> Remove the "fr/" from the URL here since that sends it to the french-locale
> page.

Is it not what is spoke by everybody ? :)

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/b2g-inbound/rev/742240197149

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/742240197149

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Blocks a blocker, needs uplifting to 1.3 to go with the other bug.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/5129f8c09d00