Closed Bug 964261 Opened 6 years ago Closed 6 years ago

Declare a widget to events created by TabParent::InjectTouchEvent

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29
blocking-b2g 1.3+
Tracking Status
firefox27 --- wontfix
firefox28 --- wontfix
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(1 file, 2 obsolete files)

Kats, I forgot to set the widget for the event. As a result it returns some weird result when we try to tap as the the coordinates hits: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#1503
Attached patch widget.sendtouchevent.patch (obsolete) — Splinter Review
Assignee: nobody → 21
Status: NEW → ASSIGNED
Attachment #8365944 - Flags: review?(bugmail.mozilla)
Attached patch widget.sendtouchevent.patch (obsolete) — Splinter Review
Attachment #8365944 - Attachment is obsolete: true
Attachment #8365944 - Flags: review?(bugmail.mozilla)
Attachment #8365963 - Flags: review?(bugmail.mozilla)
Comment on attachment 8365963 [details] [diff] [review]
widget.sendtouchevent.patch

Review of attachment 8365963 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/TabParent.cpp
@@ +1933,5 @@
>                                    aRotationAngles[i],
>                                    aForces[i]);
> +
> +    if (msg == NS_TOUCH_END || msg == NS_TOUCH_CANCEL) {
> +      t->mChanged = true;

Why this? Please add a comment explaining why this is needed.
Does the comment help ?
Attachment #8365963 - Attachment is obsolete: true
Attachment #8365963 - Flags: review?(bugmail.mozilla)
Attachment #8366274 - Flags: review?(bugmail.mozilla)
Comment on attachment 8366274 [details] [diff] [review]
widget.sendtouchevent.patch

Review of attachment 8366274 [details] [diff] [review]:
-----------------------------------------------------------------

It helps a bit. It doesn't fully explain why we want to treat all injected touch events as changed, but I guess that's a reasonable decision given that we're not tracking which touches are actually changing between calls to injectTouchEvent.

::: dom/ipc/TabParent.cpp
@@ +1934,5 @@
>                                    aForces[i]);
> +
> +    // Consider all injected touch events as changedTouches. For more details
> +    // about the meaning of changedTouches for each event, see
> +    // https://developer.mozilla.org/fr/docs/Web/API/TouchEvent.changedTouches

Remove the "fr/" from the URL here since that sends it to the french-locale page.
Attachment #8366274 - Flags: review?(bugmail.mozilla) → review+
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)
> Comment on attachment 8366274 [details] [diff] [review]
> widget.sendtouchevent.patch
> 
> Review of attachment 8366274 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It helps a bit. It doesn't fully explain why we want to treat all injected
> touch events as changed, but I guess that's a reasonable decision given that
> we're not tracking which touches are actually changing between calls to
> injectTouchEvent.
> 
> ::: dom/ipc/TabParent.cpp
> @@ +1934,5 @@
> >                                    aForces[i]);
> > +
> > +    // Consider all injected touch events as changedTouches. For more details
> > +    // about the meaning of changedTouches for each event, see
> > +    // https://developer.mozilla.org/fr/docs/Web/API/TouchEvent.changedTouches
> 
> Remove the "fr/" from the URL here since that sends it to the french-locale
> page.

Is it not what is spoke by everybody ? :)
https://hg.mozilla.org/mozilla-central/rev/742240197149
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks a blocker, needs uplifting to 1.3 to go with the other bug.
blocking-b2g: --- → 1.3?
blocking-b2g: 1.3? → 1.3+
You need to log in before you can comment on or make changes to this bug.