964267 - Pressing the bookmark menu button also depresses the bookmark star icon

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

On Mac, if you click and hold the bookmarks menu button, you'll see that the bookmark star icon also shows its depressed state. Those buttons should work independently of each other in that respect (as they already do on Windows)

Comment 1

[Matthew N. [:MattN]]

I thought there was a bug on file for this already but I can't find it.

Comment 2

[:Gijs (he/him)]

What about the blue star? Should that show if you have the panel open? On Windows, the left side also doesn't change state, so I would assume not... but your comment #0 didn't specify this.

Comment 3

[:Gijs (he/him)]

Attachment: fix star button pressed state on Australis,

This also adjusts the star. Leaving out the deletions of the [open] hunks would fix only the pressed state, without affecting the blue star showing.

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I agree, the blue star should not show up when the panel opens – just as on Windows.

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8373722 [details] [diff] [review]
fix star button pressed state on Australis,

Review of attachment 8373722 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the side-note that I don't see any use for the blue arrow at all anymore, am I right? If so, we better remove it from Toolbar.png altogether.

Comment 6

[:Gijs (he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #5)
> Comment on attachment 8373722 [details] [diff] [review]
> fix star button pressed state on Australis,
> 
> Review of attachment 8373722 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with the side-note that I don't see any use for the blue arrow at all
> anymore, am I right? If so, we better remove it from Toolbar.png altogether.

(I'm guessing you mean blue star)

Yes, but that can be a low-prio followup.

There's something to be said for using it when the 'edit bookmark' panel drops down from the star. Unfortunately, we already use a yellow star in that case (because the page is bookmarked) and so overriding that with the blue star would be a little weird... in any case, for now this will fix things up to be non-super-weird, and we can decide on what 'perfect' means in this area in another bug, which I will file in a sec. :-)

remote:   https://hg.mozilla.org/integration/fx-team/rev/690e76bd7d90

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/690e76bd7d90

Comment 8

[:Gijs (he/him)]

Comment on attachment 8373722 [details] [diff] [review]
fix star button pressed state on Australis,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: OS X star icon looks odd when clicking its menu button part
Testing completed (on m-c, etc.): m-c, locally
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/815cc4df7bbb

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0

Verified fixed on latest Aurora (build ID: 20140324004000) and on Firefox 29 beta 1(build ID: 20140318013849).