[b2gpopulate] Add command line option to override b2g start timeout

RESOLVED FIXED

Status

Testing
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
When using b2gpopulate with the emulator on a slower-running VM, after populating the emulator with data, b2gpopulate times out when restarting b2g. Add a command line option to b2gpopulate to allow the user to override the default timeout of 60 seconds.
(Assignee)

Comment 1

4 years ago
This will require a change to both gaiatest and b2gpopulate.

Gaiatest (GaiaDevice) will need to be modified to be able to receive an optional timeout value in start_b2g.

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L757

Gaiatest will need to be updated and released first, before the change to b2gpopulate.
Let's try to get this in the upcoming gaiatest release.
Blocks: 963716
(Assignee)

Comment 3

4 years ago
Created attachment 8366609 [details] [review]
964280gaiatestpr.txt

This is the PR for the gaiatest part of the change.
Attachment #8366609 - Flags: review?(dave.hunt)
Comment on attachment 8366609 [details] [review]
964280gaiatestpr.txt

r=me with the nit addressed.
Attachment #8366609 - Flags: review?(dave.hunt) → review+
(Assignee)

Updated

4 years ago
Blocks: 899194
Thanks, landed in:
https://github.com/mozilla-b2g/gaia/commit/89b1df359d8a554ca8912a09d45a36feaa58701c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

4 years ago
Thanks Dave!

Re-opening for the change required for b2gpopulate itself.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

4 years ago
Created attachment 8367293 [details] [review]
link to PR: https://github.com/mozilla/b2gpopulate/pull/12

Adding the corresponding PR for the b2gpopulate side.
Attachment #8367293 - Flags: review?(dave.hunt)
Comment on attachment 8367293 [details] [review]
link to PR: https://github.com/mozilla/b2gpopulate/pull/12

See comments in pull request.
Attachment #8367293 - Flags: review?(dave.hunt) → review-

Updated

4 years ago
Depends on: 965269
(Assignee)

Comment 9

4 years ago
Comment on attachment 8367293 [details] [review]
link to PR: https://github.com/mozilla/b2gpopulate/pull/12

Thanks Dave - changes made and PR updated
Attachment #8367293 - Flags: review- → review?(dave.hunt)
Comment on attachment 8367293 [details] [review]
link to PR: https://github.com/mozilla/b2gpopulate/pull/12

Thanks! Landed in:
https://github.com/mozilla/b2gpopulate/commit/92bae023d72f9db5c5388fb78f489e1813b001cb
Attachment #8367293 - Flags: review?(dave.hunt) → review+

Updated

4 years ago
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.