Closed
Bug 964314
Opened 12 years ago
Closed 12 years ago
SoundCloud API error crashed Popcorn Maker server
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Webmaker Graveyard
Popcorn Maker
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: mjschranz)
Details
Attachments
(1 file)
When someone did a search for "scream" on SoundCloud, the SoundCloud API returned a error HTML page instead of a JSON API response.
The stack trace was:
Object <!DOCTYPE HTML>\n<html lang=\"en\"> ... long html string ... has no method 'map'
at Request._callback (/var/www/butter/node_modules/webmaker-mediasync/lib/services/soundcloud.js:37:22)
Which maps to: https://github.com/mozilla/webmaker-mediasync/blob/7023d7a8caf2f348124697f24b368c472acf3832/lib/services/soundcloud.js#L37
The crash happened at 8:11AM which meshes with the timeline on http://status.soundcloud.com/ .
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8366158 -
Flags: review?(jon)
|
Reporter | |
Updated•12 years ago
|
Attachment #8366158 -
Flags: review?(jon) → review+
|
||
Comment 2•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/de429d5da41523dc5cce3ab5b53ac004427ee25f
Fix Bug 964314 - Prevent failed soundcloud searches from crashing the server
|
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•