964345 - [DSDS] Wrong panel navigation flow for call settings and cellular and data menu items

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

After landing bug 945150 there are chances to get a wrong panel navigation flow for call settings and cellular and data menu items. The user could get access to the call settings panels without visiting the ICC card picker panel and even worse get a blank page when going back. This is a regression caused by bug 945150. This bug could be easily reproduced on fugu device by opening the settings app and clicking quickly the menu items for call settings. The same happens with the cellular and data settings.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/15735

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

Arthur, this patch fix the issue we were discussing on IRC about the issue in the panel navigation for call settings and cellular and data settings. Could you take a look at it please? Thanks!

PS. Feel free to review the patch through the PR if you prefer.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8366051 [details] [diff] [review]
v1

Thanks for the patch, Jose! 

However, the current solution has two paths of initialization and which depend on which helper's init function gets called at first. This makes the code less readable and less robust. Can we call to DsdsSettings's init function from TelephonySettingHelper's init function? I mean move the adding of the idle observer from dsds_settings.js to the init function of TelephonySettingHelper. So that we can make sure DsdsSettings is initialized before initializing TelephonySettingHelper.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v2

Arthur, review comments from comment #3 addressed. Could you take a look a it again, please? Thanks.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8366506 [details] [diff] [review]
v2

r=me. Thank you for the patch!

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Thanks Arthur, landed on Gaia master branch at https://github.com/mozilla-b2g/gaia/commit/719c2650a53dcfa22689898cb82c3826d17eb1b2

Comment 7

[Preeti Raghunath(:Preeti)]

1.3+ for broken feature

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 719c2650a53dcfa22689898cb82c3826d17eb1b2 to:
v1.3: 4fe8dc01727741b28a7fcf025709d06693cdd2be