964358 - browser_newtab_focus.js leaks in debug mode when run as a standalone directory

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in working on running browser-chrome tests per directory instead of as a single large chunk, I found in debug mode some tests would leak:
leakcheck | 5319 bytes leaked (DOMStorageManager, EventTokenBucket, Mutex, ReentrantMonitor, SpdySession31, ...)

In this case, when I run with test-path: browser/base/content/test/newtab, I get leaks.  If I remove browser_newtab_focus.js from the list of tests we run, I get no leaks.

Comment 1

[Matthew N. [:MattN]]

This is from the speculative connection we do on new tab tiles. See bug 964369.

https://mxr.mozilla.org/mozilla-central/source/browser/base/content/newtab/sites.js?rev=f3c44cfc3900#182

Comment 2

[Ed Lee :Mardak]

jmaher, are you running on a clean test profile? It seems odd that the newtab tests would have something triggering SpdySession31 objects. We found in our tests of debugging bug 990713 that google-related sites, facebook, twitter implement Spdy.

Comment 3

[Matthew N. [:MattN]]

Actually, now that I read the test, it's essentially tabbing through all focusable elements starting from the URL bar so it's just focusing the search bar and running into the same thing as bug 964369. This may not really be specific to the tiles and the default search engine is Google (which uses SPDY) in the test runs AFAIK.

Comment 4

[Ed Lee :Mardak]

Is it expected to have all these browser chrome test instances triggering connections to google.com to establish Spdy?

Comment 5

[Matthew N. [:MattN]]

No, I don't think so which is why I'm writing a patch to disable speculative connections by default in tests. I'll have to see what Necko people think about that approach though.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

first off we should have no connections going to google.com or any real outside location.  

When this is run, it is with a fresh brand new profile for each directory.

Comment 7

[Ed Morley [:emorley]]

(In reply to Joel Maher (:jmaher) from comment #6)
> first off we should have no connections going to google.com or any real
> outside location.  

I'm re-pinging bug 617414; we should fix this once and for all.

Comment 8

[Ed Lee :Mardak]

Test was removed in bug 1433133 https://hg.mozilla.org/mozilla-central/rev/fc80dd3e4fae