Closed Bug 964400 Opened 7 years ago Closed 7 years ago

Compose window alignment tweak on Linux

Categories

(Thunderbird :: Theme, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 29.0

People

(Reporter: alta88, Assigned: Paenglab)

Details

Attachments

(4 files)

Attached image Screenshot.png
Screenshot of misaligned From:, with the email text, and with the '1 attachment' label text.  All should baseline align.
Also, I tend to think it will look nicer if the : of From: and To: also align vertically.  It's a nit, and perhaps not simple given the widgets and font size variations etc.
Attached patch patchSplinter Review
This patch aligns the attachment header and also aligns horizontally the identity and subject labels with the textboxes.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8366213 - Flags: ui-review?(josiah)
Attachment #8366213 - Flags: review?(josiah)
Attached image Patch in action
(In reply to alta88 from comment #1)
> Also, I tend to think it will look nicer if the : of From: and To: also
> align vertically.  It's a nit, and perhaps not simple given the widgets and
> font size variations etc.

This could maybe done in bug 962672 when the menulist no more uses the system widget.
Comment on attachment 8366213 [details] [diff] [review]
patch

Review of attachment 8366213 [details] [diff] [review]:
-----------------------------------------------------------------

This looks pretty good. While you're here though, could you add some padding to the attachment bucket sizer? It currently seems to be too close to the attachment box.
Attachment #8366213 - Flags: ui-review?(josiah)
Attachment #8366213 - Flags: ui-review+
Attachment #8366213 - Flags: review?(josiah)
Attachment #8366213 - Flags: review+
Attached image Adwaita splitter
(In reply to Josiah Bruner [:JosiahOne] from comment #5)
> Comment on attachment 8366213 [details] [diff] [review]
> patch
> 
> Review of attachment 8366213 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks pretty good. While you're here though, could you add some padding
> to the attachment bucket sizer? It currently seems to be too close to the
> attachment box.

This is the style of the Linux theme I'm using. With Adwaita as theme it looks normal.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2f2fa58f41a7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in before you can comment on or make changes to this bug.