Closed
Bug 964400
Opened 12 years ago
Closed 12 years ago
Compose window alignment tweak on Linux
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: alta88, Assigned: Paenglab)
Details
Attachments
(4 files)
|
60.14 KB,
image/png
|
Details | |
|
3.20 KB,
patch
|
jsbruner
:
review+
jsbruner
:
ui-review+
|
Details | Diff | Splinter Review |
|
63.09 KB,
image/png
|
Details | |
|
8.54 KB,
image/png
|
Details |
Screenshot.png
Screenshot of misaligned From:, with the email text, and with the '1 attachment' label text. All should baseline align.
Also, I tend to think it will look nicer if the : of From: and To: also align vertically. It's a nit, and perhaps not simple given the widgets and font size variations etc.
|
Assignee | |
Comment 2•12 years ago
|
||
This patch aligns the attachment header and also aligns horizontally the identity and subject labels with the textboxes.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8366213 -
Flags: ui-review?(josiah)
Attachment #8366213 -
Flags: review?(josiah)
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to alta88 from comment #1)
> Also, I tend to think it will look nicer if the : of From: and To: also
> align vertically. It's a nit, and perhaps not simple given the widgets and
> font size variations etc.
This could maybe done in bug 962672 when the menulist no more uses the system widget.
|
||
Comment 5•12 years ago
|
||
Comment on attachment 8366213 [details] [diff] [review]
patch
Review of attachment 8366213 [details] [diff] [review]:
-----------------------------------------------------------------
This looks pretty good. While you're here though, could you add some padding to the attachment bucket sizer? It currently seems to be too close to the attachment box.
Attachment #8366213 -
Flags: ui-review?(josiah)
Attachment #8366213 -
Flags: ui-review+
Attachment #8366213 -
Flags: review?(josiah)
Attachment #8366213 -
Flags: review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
(In reply to Josiah Bruner [:JosiahOne] from comment #5)
> Comment on attachment 8366213 [details] [diff] [review]
> patch
>
> Review of attachment 8366213 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> This looks pretty good. While you're here though, could you add some padding
> to the attachment bucket sizer? It currently seems to be too close to the
> attachment box.
This is the style of the Linux theme I'm using. With Adwaita as theme it looks normal.
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•