964425 - Remove msgFolderPickerOverlay.dtd from /mail/

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Attachment: patch, v1

Bug 878805 made some l10n string uses obsolete. According to MXR, msgFolderPickerOverlay.dtd from /mail/ doesn't get used anymore: http://mxr.mozilla.org/comm-central/search?string=msgFolderPickerOverlay.dtd&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

/suite/ uses the one from /suite/locales/en-US/chrome/mailnews/

There are some add-ons using the removed file (ignoring incompatible add-ons):

https://addons.mozilla.org/en-US/thunderbird/addon/auto-save-drafts-folders/ by dlech
https://addons.mozilla.org/en-US/thunderbird/addon/exquilla-exchange-web-services/ by rkent
https://addons.mozilla.org/en-US/thunderbird/addon/copy-sent-to-current/ and https://addons.mozilla.org/en-US/thunderbird/addon/addressbooks-synchronizer/ by Neandr
https://addons.mozilla.org/en-US/thunderbird/addon/unified-search-187593/ by IagoSRL
https://addons.mozilla.org/en-US/thunderbird/addon/archive-this/ by Adam Roach
https://addons.mozilla.org/en-US/thunderbird/addon/manualjunkaction/ by Ryan Lee

Comment 1

[Günter]

https://addons.mozilla.org/en-US/thunderbird/addon/addressbooks-synchronizer/ by Neandr

Not correct!

It's pointing to 
Addressbooks Synchronizer 1.0.8  by Guenter Gersdorf

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8366164 [details] [diff] [review]
patch, v1

rs=me, although we'll probably want to post about this on tb-planning and mdat before landing it.

Comment 3

[:aceman]

The folder picker specific strings are now being collected to folderWidgets.properties .

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Attachment: patch, v2, r=squib

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/3edad2919f73

Comment 6

[Adam Roach [:abr]]

(In reply to Archaeopteryx [:aryx] from comment #0)
> 
> There are some add-ons using the removed file (ignoring incompatible
> add-ons):
> https://addons.mozilla.org/en-US/thunderbird/addon/archive-this/ by Adam Roach


Yep; a CC would have been appreciated. :)