Closed
Bug 964437
Opened 10 years ago
Closed 10 years ago
Aurora 28 branch still uses NSPR beta, please upgrade to NSPR 4.10.3 RTM tag
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox28+ fixed, firefox29+ fixed, firefox30 fixed)
RESOLVED
FIXED
mozilla28
People
(Reporter: KaiE, Assigned: keeler)
Details
Attachments
(1 file)
17.99 KB,
patch
|
wtc
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Can you please import NSPR 4.10.3 into the aurora 28 branch? python client.py update_nspr NSPR_4_10_3_RTM
Reporter | ||
Updated•10 years ago
|
status-firefox28:
--- → affected
tracking-firefox28:
--- → ?
Comment 1•10 years ago
|
||
This is the same as updating NSS, except use "update_nspr" instead of "update_nss". I think the tag should be NSPR_4_10_3_RTM.
Assignee: nobody → dkeeler
Reporter | ||
Comment 2•10 years ago
|
||
This upgrade is necessary, because Mozilla never ships NSPR-BETA versions in releases, only RTM-versions, and aurora currently uses a beta.
Attachment #8366196 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8366196 [details] [diff] [review] p-964437 Review of attachment 8366196 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Brian Smith (:briansmith, :bsmith; NEEDINFO? for response) from comment #1) > This is the same as updating NSS, except use "update_nspr" instead of > "update_nss". I think the tag should be NSPR_4_10_3_RTM. FWIW, I ran `./client.py update_nspr NSPR_4_10_3_RTM && hg addremove`... and got the same patch as this.
Comment 4•10 years ago
|
||
Comment on attachment 8366196 [details] [diff] [review] p-964437 Review of attachment 8366196 [details] [diff] [review]: ----------------------------------------------------------------- r=wtc.
Attachment #8366196 -
Flags: review+
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8366196 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 5•10 years ago
|
||
Thank you for the approval. https://hg.mozilla.org/releases/mozilla-aurora/rev/0386e163f0f7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-firefox29:
--- → unaffected
Target Milestone: --- → mozilla28
Reporter | ||
Comment 6•10 years ago
|
||
We must do the same thing for Aurora 29. (I had forgotten to land the update into mozilla-central prior to the most recent merge.)
Reporter | ||
Comment 7•10 years ago
|
||
May we reuse the approval-aurora?
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(lsblakk)
Comment 8•10 years ago
|
||
Yes - will this need to happen again for future versions or am I correct in marking it 'fixed' on 30?
Reporter | ||
Comment 9•10 years ago
|
||
(In reply to Lukas Blakk [:lsblakk] from comment #8) > Yes thank you! > will this need to happen again for future versions or am I correct in > marking it 'fixed' on 30? Yes, 30 already won't need an update to 4.10.3 RTM, because 30 already uses 4.10.4 beta
Reporter | ||
Comment 10•10 years ago
|
||
fixed on 29. https://hg.mozilla.org/releases/mozilla-aurora/rev/6c70ddf78844
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•