Closed Bug 964437 Opened 10 years ago Closed 10 years ago

Aurora 28 branch still uses NSPR beta, please upgrade to NSPR 4.10.3 RTM tag

Categories

(Firefox Build System :: General, defect)

28 Branch
defect
Not set
normal

Tracking

(firefox28+ fixed, firefox29+ fixed, firefox30 fixed)

RESOLVED FIXED
mozilla28
Tracking Status
firefox28 + fixed
firefox29 + fixed
firefox30 --- fixed

People

(Reporter: KaiE, Assigned: keeler)

Details

Attachments

(1 file)

Can you please import NSPR 4.10.3 into the aurora 28 branch?

python client.py update_nspr NSPR_4_10_3_RTM
This is the same as updating NSS, except use "update_nspr" instead of "update_nss". I think the tag should be NSPR_4_10_3_RTM.
Assignee: nobody → dkeeler
Attached patch p-964437Splinter Review
This upgrade is necessary, because Mozilla never ships NSPR-BETA versions in releases, only RTM-versions, and aurora currently uses a beta.
Attachment #8366196 - Flags: approval-mozilla-aurora?
Comment on attachment 8366196 [details] [diff] [review]
p-964437

Review of attachment 8366196 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Brian Smith (:briansmith, :bsmith; NEEDINFO? for response) from comment #1)
> This is the same as updating NSS, except use "update_nspr" instead of
> "update_nss". I think the tag should be NSPR_4_10_3_RTM.

FWIW, I ran `./client.py update_nspr NSPR_4_10_3_RTM && hg addremove`... and got the same patch as this.
Comment on attachment 8366196 [details] [diff] [review]
p-964437

Review of attachment 8366196 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.
Attachment #8366196 - Flags: review+
Attachment #8366196 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Thank you for the approval.
https://hg.mozilla.org/releases/mozilla-aurora/rev/0386e163f0f7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
We must do the same thing for Aurora 29.

(I had forgotten to land the update into mozilla-central prior to the most recent merge.)
May we reuse the approval-aurora?
Flags: needinfo?(lsblakk)
Yes - will this need to happen again for future versions or am I correct in marking it 'fixed' on 30?
Flags: needinfo?(lsblakk)
(In reply to Lukas Blakk [:lsblakk] from comment #8)
> Yes 

thank you!


> will this need to happen again for future versions or am I correct in
> marking it 'fixed' on 30?

Yes, 30 already won't need an update to 4.10.3 RTM, because 30 already uses 4.10.4 beta
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.