964468 - Add some padding between the input field and the search/filter button

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Reviewer Tools, defect, P5)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace.firefox.com/reviewers/apps/logs
2. Notice the Filter button
3. Load https://marketplace.firefox.com/reviewers/apps/queue/
4. Notice the Search button


observed behavior:
Add some padding between the input field and the search/filter button

Comment 1

[Rachel]

The forms could use a little styling love, imo, but it looks to me like the button is supposed to be right next to the input in both of these cases. The buttons don't have a border-radius set on their left sides, which makes me think the inputs and buttons together are supposed to look like a single field. Thoughts?

Comment 2

[Wil Clouser [:clouserw]]

I think it would look better as a separate field.  There are 3 text boxes being submitted with the button, if there was only one a joined field would be reasonable.

Comment 3

[Ram Dayal Vaishnav [:ram]]

If following questions are answered, this will be very much helpful for newbies pick and fix this good-first-bug :

- Can it be fixed from Fireplace itself? 
- How to get permissions on Fireplace/Docker to access reviewer tools (by default we cannot access then, right?).

Thanks,
Ram

Comment 4

[Andy McKay]

Reviewer tools are not part of fireplace, but in zamboni. You will need to give your zamboni user account, permission to access them. A simple way to do this is documented here:

http://marketplace.readthedocs.org/en/latest/topics/backend-details.html#how-do-i-add-an-admin-in-zamboni-with-docker

Comment 5

[frescoshashank]

I want to work on this Bug, This needs a backend of fireplace to be installed so i tried installing the backend using the instructions provided at 

http://marketplace.readthedocs.org/en/latest/topics/backend.html

But while pulling the docker images and building the containers I'm facing the below issue

raise StreamOutputError(event['errorDetail']['message'])
compose.progress_stream.StreamOutputError: Error pulling image (latest) from mozillamarketplace/spartacus, Untar re-exec error: exit status 1: output: unexpected EOF

Can you please help me out why actually i'm facing this issue? 

I'll try to do it again but until then if you could suggest me any solution then let me know!

Comment 6

[Ram Dayal Vaishnav [:ram]]

Sure Shashank, Assigning you. For any help, feel free to refer to marketplace documentation at http://marketplace.readthedocs.org/ or use #marketplace irc.

Putting NI for andy for comment#5.

Comment 7

[Andreas Wagner [:TheOne] [use NI]]

Shashank, could you work it out? Do you need additional help?

Comment 8

[Andreas Wagner [:TheOne] [use NI]]

The risk of fixing this and breaking the UI somewhere else more user facing is too high, WONTFIX.

Comment 9

[Ram Dayal Vaishnav [:ram]]

Hi Shashank, Since this is no more an good bug to work on (as per above comment), can you please pick some other bug and work on that? You can find list of all good-first-bugs at - https://bugzilla.mozilla.org/buglist.cgi?cmdtype=runnamed&namedcmd=mp-good-first-bugs