964484 - --disable-webm builds are broken. (--disable-webm needs to be removed)

Status: RESOLVED DUPLICATE of bug 1232223

(Core :: Audio/Video: Playback, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 891705 seems to have broken --disable-webm builds. Before its cset landed, I could build; now I cannot (unless I install libvpx-dev, which rillian says I shouldn't have to do).

In particular, I get this build failure:
{
media/libmkv/EbmlWriter.h:18:10: fatal error: 'vpx/vpx_integer.h' file not found
#include "vpx/vpx_integer.h"
          ^
}

I think this is just related to --disable-webm, but FWIW, here's my mozconfig:
{
ac_add_options --enable-debug --disable-optimize
ac_add_options --disable-crashreporter
ac_add_options --disable-installer
ac_add_options --disable-updater
ac_add_options --enable-valgrind
ac_add_options --enable-warnings-as-errors
ac_add_options --enable-profiling
ac_add_options --disable-accessibility
ac_add_options --disable-gamepad
ac_add_options --disable-gstreamer
ac_add_options --disable-jsd
ac_add_options --disable-ogg
ac_add_options --disable-opus
ac_add_options --disable-universalchardet
ac_add_options --disable-necko-wifi
ac_add_options --disable-wave
ac_add_options --disable-webapp-runtime
ac_add_options --disable-webgl
ac_add_options --disable-webm
ac_add_options --disable-webrtc
ac_add_options --disable-webspeech
ac_add_options --without-intl-api
}

Comment 1

[Ralph Giles (:rillian)]

Ok, --disable-webm probably prevents the libvpx header export. We should either make the encoder conditional on MOZ_WEBM or remove the switch altogether. I propose the later.

Comment 2

[Daniel Holbert [:dholbert]]

(See also bug 964488, BTW.)

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi Bengamin, 
Please help this, thanks a lot.

Comment 4

[Daniel Holbert [:dholbert]]

Note that rillian has suggested getting rid of some of these "--disable-codec" options entirely (e.g. bug 964559), which would make this a non-issue.

(Not sure if "--disable-webm" is on the chopping block or not; CC'ing him so he can chime in.)

Comment 5

[Daniel Holbert [:dholbert]]

[er, right, he suggested removing --disable-webm here, in comment 1. Sorry, didn't scroll back far enough.]

Comment 6

[Petr Cerny [:hrosik]]

(In reply to Ralph Giles (:rillian) from comment #1)
> Ok, --disable-webm probably prevents the libvpx header export. We should
> either make the encoder conditional on MOZ_WEBM or remove the switch
> altogether. I propose the later.

What exactly would removing --disable-webm mean? That it would always be built? What would happen when yasm is not present?

Comment 7

[Ralph Giles (:rillian)]

Yes, webm support would always be compiled in, and yasm would be required for the build.

Comment 8

[Daniel Holbert [:dholbert]]

FWIW, --disable-webm still exists as a config option, though now the first bustage I hit with that in my mozconfig is:
{
dom/media/mediasource/ContainerParser.cpp:9:10: fatal error: 'WebMBufferedParser.h' file not found
}