Closed
Bug 964513
Opened 11 years ago
Closed 11 years ago
[AccessFu] Skip empty headings and headers
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(1 file, 1 obsolete file)
|
5.99 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
Empty headings are landed upon with the cursor. They should be skipped.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8366272 -
Flags: review?(yzenevich)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8366272 [details] [diff] [review]
Skip empty headers.
Can we have a test for this somehow?
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8366272 [details] [diff] [review]
Skip empty headers.
Review of attachment 8366272 [details] [diff] [review]:
-----------------------------------------------------------------
It looks good. I'll r+ it once there are tests, as Marco suggested.
Attachment #8366272 -
Flags: review?(yzenevich)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8366272 -
Attachment is obsolete: true
Attachment #8367635 -
Flags: review?(yzenevich)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8367635 [details] [diff] [review]
Skip empty headers.
Review of attachment 8367635 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8367635 -
Flags: review?(yzenevich) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Assignee: nobody → eitan
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•