[AccessFu] Skip empty headings and headers

RESOLVED FIXED in mozilla30

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla30
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Empty headings are landed upon with the cursor. They should be skipped.
(Assignee)

Comment 1

5 years ago
Created attachment 8366272 [details] [diff] [review]
Skip empty headers.
Attachment #8366272 - Flags: review?(yzenevich)

Comment 2

5 years ago
Comment on attachment 8366272 [details] [diff] [review]
Skip empty headers.

Can we have a test for this somehow?
Comment on attachment 8366272 [details] [diff] [review]
Skip empty headers.

Review of attachment 8366272 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good. I'll r+ it once there are tests, as Marco suggested.
Attachment #8366272 - Flags: review?(yzenevich)
(Assignee)

Comment 4

5 years ago
Created attachment 8367635 [details] [diff] [review]
Skip empty headers.
Attachment #8366272 - Attachment is obsolete: true
Attachment #8367635 - Flags: review?(yzenevich)
Comment on attachment 8367635 [details] [diff] [review]
Skip empty headers.

Review of attachment 8367635 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8367635 - Flags: review?(yzenevich) → review+
https://hg.mozilla.org/mozilla-central/rev/f3d031c9648c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.