964528 - Compilation fails with --disable-opus, when building content/media/DecoderTraits.cpp, with "OpusParser.h:11:10: fatal error: 'opus/opus.h' file not found"

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

When building mozilla-central with this .mozconfig:
{
ac_add_options --disable-opus
ac_add_options --disable-webrtc
}

...I get this build failure:
{
 0:10.26 In file included from /mozilla-central/content/media/DecoderTraits.cpp:18:
 0:10.26 In file included from ../../dist/include/OggReader.h:17:
 0:10.26 In file included from ../../dist/include/OggCodecState.h:39:
 0:10.26 ../../dist/include/OpusParser.h:11:10: fatal error: 'opus/opus.h' file not found
 0:10.26 #include <opus/opus.h>
 0:10.26          ^
 0:10.98 1 error generated.
}

Comment 1

[Daniel Holbert [:dholbert]]

(Note: the "--disable-webrtc" isn't likely to be involved here -- it's only in my sample .mozconfig because WebRTC code depends on Opus, which means "--disable-opus" by itself will cause a build failure during the configure.in-processing steps, unless you also disable webrtc.)

Comment 2

[Daniel Holbert [:dholbert]]

I don't immediately see why, but local testing indicates that this issue was introduced by Bug 891705's commit.

In other words:
* A build from https://hg.mozilla.org/mozilla-central/rev/a331400db013 hits this build error.
* A build from that cset's parent, faecbc4a1b4b, completes successfully.

(with both builds using the mozconfig from comment 0)

Comment 3

[Daniel Holbert [:dholbert]]

Sorry, disregard comment 2; I've now reproduced this in a build from faecbc4a1b4b, too. So, this issue predated Bug 891705.

Comment 4

[Daniel Holbert [:dholbert]]

RE dependency on bug 964559: I just tested that bug's patch, and it does not fix the issue described in this bug here, FWIW.

(not sure if the dependency was meant to indicate that it would fix this)

Comment 5

[Daniel Holbert [:dholbert]]

(Ah, you probably meant to make that bug block bug 964488 (about --disable-ogg), rather than this bug here (about --disable-opus), I'm guessing).

Comment 6

[Ralph Giles (:rillian)]

Yes, sorry for the confusion. Removing --disable-ogg is also a prerequisite for removing --disable-opus, which is how I'd like to resolve this issue as well.

Comment 7

[Daniel Holbert [:dholbert]]

OK, makes sense. Thanks!

Comment 8

[maillist-mozilla]

issue is still existing in 29.0.1
--enable-ogg + --disable-opus leads to the above mentioned build error

DecoderTraits.o
c++ -o DecoderTraits.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /src/build/fire$
Latency.o
In file included from ../../dist/include/OggCodecState.h:39:0,
                 from ../../dist/include/OggReader.h:17,
                 from /src/build/firefox/mozilla-release/content/media/DecoderTraits.cpp:18:
../../dist/include/OpusParser.h:11:23: fatal error: opus/opus.h: No such file or directory
compilation terminated.
make[5]: *** [DecoderTraits.o] Error 1
make[5]: Leaving directory `/src/build/firefox/mozilla-release/firefox-build-dir/content/media'
make[4]: *** [content/media/compile] Error 2
make[4]: *** Waiting for unfinished jobs....

Comment 9

[Ralph Giles (:rillian)]

Resolved by bug 1100632.