964534 - [AccessFu] Move cursor when dialog appears

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

When a dialog appears, move cursor into the dialog.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Move cursor to new dialog if focus does not change the cursor first.

Comment 2

[Yura Zenevich [:yzen]]

Comment on attachment 8366322 [details] [diff] [review]
Move cursor to new dialog if focus does not change the cursor first.

Review of attachment 8366322 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with some comments.

::: accessible/src/jsat/EventManager.jsm
@@ +274,5 @@
>          // Put vc where the focus is at
>          let acc = aEvent.accessible;
>          let doc = aEvent.accessibleDocument;
>          if (acc.role != Roles.DOCUMENT && doc.role != Roles.CHROME_WINDOW) {
> +          this._focusMove = false;

if we use the |this._autoFocus| described below this would be:
this.contentScope.content.clearTimeout(this._autoFocus);

If this stays, at discussed, it should be this._focusMove = true;

@@ +283,5 @@
>        }
> +      case Events.DOCUMENT_LOAD_COMPLETE:
> +      {
> +        this._focusMove = false;
> +        this.contentScope.content.setTimeout(() => {

What if we use |this._autoFocus| then we don't have to do anything related to the flag inside the timeout callback:

this._autoFocus = this.contentScope.content.setTimeout(() => {
  let vc = Utils.getVirtualCursor(aEvent.accessibleDocument);
  vc.moveNext(TraversalRules.Simple, aEvent.accessible, true);
}, 500);

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49e73a6d4c06

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49e73a6d4c06