Remove custom node binary (and associated hackery)

RESOLVED FIXED in mozilla30

Status

Testing
XPCShell Harness
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nwgh, Assigned: nwgh)

Tracking

unspecified
mozilla30
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Landing of http/2 code added a custom node binary to work around an old version on infrastructure. Infrastructure now has a workable version of node, so we can get rid of that.

This patch also makes testing spdy and http/2 slightly separate from each other, so that if one server fails to start up for whatever reason, we'll still be able to test the other one (assuming its server starts up, of course).
Created attachment 8366341 [details] [diff] [review]
patch
Attachment #8366341 - Flags: review?(ted)
Try run proving goodness on infra: https://tbpl.mozilla.org/?tree=Try&rev=2a1224faed51
Comment on attachment 8366341 [details] [diff] [review]
patch

Review of attachment 8366341 [details] [diff] [review]:
-----------------------------------------------------------------

The hasNodeSpdy / hasNodeHttp2 bit feels like overkill. It's okay to just fail if we can't start a server, that's an unlikely occurrence anyway. The rest of the patch looks fine.
Attachment #8366341 - Flags: review?(ted) → review-
Created attachment 8370266 [details] [diff] [review]
remove_custom_node.patch

New version without the extra keys. New try run, just to make sure I didn't mess up the changes: https://tbpl.mozilla.org/?tree=Try&rev=8a187d78fd95
Attachment #8366341 - Attachment is obsolete: true
Attachment #8370266 - Flags: review?(ted)
Attachment #8370266 - Flags: review?(ted) → review+
Thanks, Ted! Try is green.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/da6cdcc7b7b3
https://hg.mozilla.org/mozilla-central/rev/da6cdcc7b7b3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.