964563 - Remove custom node binary (and associated hackery)

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[u408661]

Landing of http/2 code added a custom node binary to work around an old version on infrastructure. Infrastructure now has a workable version of node, so we can get rid of that.

This patch also makes testing spdy and http/2 slightly separate from each other, so that if one server fails to start up for whatever reason, we'll still be able to test the other one (assuming its server starts up, of course).

Comment 1

[u408661]

Attachment: patch

Comment 2

[u408661]

Try run proving goodness on infra: https://tbpl.mozilla.org/?tree=Try&rev=2a1224faed51

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8366341 [details] [diff] [review]
patch

Review of attachment 8366341 [details] [diff] [review]:
-----------------------------------------------------------------

The hasNodeSpdy / hasNodeHttp2 bit feels like overkill. It's okay to just fail if we can't start a server, that's an unlikely occurrence anyway. The rest of the patch looks fine.

Comment 4

[u408661]

Attachment: remove_custom_node.patch

New version without the extra keys. New try run, just to make sure I didn't mess up the changes: https://tbpl.mozilla.org/?tree=Try&rev=8a187d78fd95

Comment 5

[u408661]

Thanks, Ted! Try is green.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/da6cdcc7b7b3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da6cdcc7b7b3