964580 - [l10n] The FM's app name in zh-TW is incorrect

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

In Traditional Chinese, it should be '收音機' rather than '收音机'. The '机' is Simplified Chinese character.

Comment 1

[colin]

Pull request here: https://github.com/mozilla-b2g/gaia/pull/18710

Comment 2

[Omega Feng [:Omega] [:馮於懋]]

Hi Hema, can you review the PR in comment 1?

Comment 3

[Hema Koka [:hema]]

Adding Pin Zhang for review

Comment 4

[Pin Zhang [:pzhang] (inactive)]

Attachment: pr18710

Comment 5

[Eric Chou [:ericchou] [:echou]]

Is there any reason that this issue is still open even the PR has got r+? :|

Comment 6

[Kai-Chih Hu [:khu]]

Based on the comment from autolander on Oct 2nd: 
"This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience."
https://github.com/mozilla-b2g/gaia/pull/18710

Comment 7

[Kai-Chih Hu [:khu]]

I can take this bug and land it again.

Comment 8

[Kai-Chih Hu [:khu]]

Attachment: Patch 27034

Comment 9

[Francesco Lodolo [:flod]]

Do you realize that locales on Github are not real locales, don't you? See also bug 1099321.

Comment 10

[Kai-Chih Hu [:khu]]

(In reply to Francesco Lodolo [:flod] from comment #9)
> Do you realize that locales on Github are not real locales, don't you? See
> also bug 1099321.

Sorry, I did not know that. Will take a look on bug 1099321. Thanks for the sharing.

Comment 11

[Francesco Lodolo [:flod]]

For reference this is the correct locale file (for master), and AFAICT it looks correct
https://hg.mozilla.org/gaia-l10n/zh-TW/file/0d6aeb485310/apps/fm/manifest.properties

Comment 12

[Kai-Chih Hu [:khu]]

Thank you, Francesco. It's very helpful. 

So, my understanding is that, we need to remove the zh-TW string from master, and keep the localized string in l10n folders. Please correct me if I am wrong. If it's correct, I will submit another patch. Thank you.

Comment 14

[Francesco Lodolo [:flod]]

(In reply to Kevin Hu [:khu] from comment #12)
> So, my understanding is that, we need to remove the zh-TW string from
> master, and keep the localized string in l10n folders. 

As I said strings will be removed at some point in bug 1099321. 

The strings currently in Gaia are not used for multi-locale builds anyway, they were probably added at the beginning for testing reasons, but they're not maintained in terms of both updating and checking for errors, and they're only a source of confusion these days.

For proper testing we have pseudolocales integrated in the system now (built at runtime).

Comment 15

[Kai-Chih Hu [:khu]]

Will someone remove these useless strings? 
I checked the file and these strings are still there...

Comment 16

[Francesco Lodolo [:flod]]

(In reply to Kevin Hu [:khu] from comment #15)
> I checked the file and these strings are still there...

Where? 
https://github.com/mozilla-b2g/gaia/tree/master/apps/fm/locales

2.2 is out of scope at this point, master is fixed.

Comment 17

[Kai-Chih Hu [:khu]]

Looks like this bug can be closed now.