According to the user story in Bug 922927, we have to implement following items for reaching the user story. 1. If USB storage is disabled, grey out "Share using USB" toggle button.(This is an improving item for interaction.) 2. Remove "USB storage toggle button" from Settings::Media storage. 3. Let the MTP is always enabled.(Gaia is able to control the flag while platform is ready to support.)
For the item 3, it will need MTP supporting via platform. Then, it's able to toggle MTP enabled/disabled via settings key.
In transfer protocol page, will set ums.mode : 1 -> UMS ums.mode : 3 -> MTP based on bug 1043264 comment 6
Ian will handle origin media storage related change in bug 943825. I'd help make new usb_storage panel The new spec is: 1. add new link left of USB storage switch 2. add a protocol selection panel contains (mtp / ums) (set mtp by default) 3. change mode based on protocol selection result
Created attachment 8475742 [details] [review] pull request redirect to github WIP for gecko test, need refactor and unit test
I would have thought that UMS should be set by default, since that's what we've been using in the past. Making MTP be the default seems a bit premature right now, especially since its new, and we know it doesn't work anywhere near as reliably as UMS.
ni jenny(UX) to clarify Dave's comment 6 about why set MTP by default. From tech perspective, ni alphan, if Dave and you feel UMS is better fit for current release, we should do that and fire followup bug to change default to MTP for future release.
In my opinion, if there is UMS support, it is good to set UMS as default. UMS is more stable and faster than MTP. As Dave said, UMS can work well on anywhere but MTP can't.
If there's technical concerns, I'm ok with using UMS as default. However, when MTP is stabilized in the future, we should switch back to MTP. Thank you!
Comment on attachment 8475742 [details] [review] pull request redirect to github set feedback flag to get some feedback before unit tests are done.
Comment on attachment 8475742 [details] [review] pull request redirect to github F+ for settings part. Please check my comments on Github ! Thanks ;)
Comment on attachment 8475742 [details] [review] pull request redirect to github Thanks EJ for feedback. Unit test added. Set review for system part. will set settings review after add the split menu UI.
Comment on attachment 8475742 [details] [review] pull request redirect to github split menu added, @ej please help review it. Thanks!
Created attachment 8478152 [details] screenshot set UI review
Comment on attachment 8478152 [details] screenshot Hi Fred, it looks good! Thank you!
Comment on attachment 8475742 [details] [review] pull request redirect to github r+ with nits
Comment on attachment 8475742 [details] [review] pull request redirect to github Thanks Fred, r+ with nits on Github. :)
Thanks for review. I've addressed your comments, will fix TBPL test issue before land.
Confirmed with EM/EPM, and this can be landed before FL.