Closed Bug 964700 Opened 9 years ago Closed 9 years ago

Make the errors logged by Parser.jsm also contain the problematic source url

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 29

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file)

v1
3.24 KB, patch
past
: review+
Details | Diff | Splinter Review 
I used the browser debugger today. I typed @ and a few characters in the searchbox to find a function. The error spew in stdout told me that Parser.jsm is having a bad time, however it didn't tell me what was the actual source that couldn't be parsed correctly.
Attached patch v1 — — Splinter Review 
Assignee: nobody → vporof
Status: NEW → ASSIGNED

        Attachment #8366557 -
        Flags: review?(past)

    
    

    
  
Comment on attachment 8366557 [details] [diff] [review]
v1

Review of attachment 8366557 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

        Attachment #8366557 -
        Flags: review?(past) → review+

    
    

    
  
had to back this change out because of XPCShell bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=33687468&tree=Fx-Team

    
    

    
  
Relanded: https://hg.mozilla.org/integration/fx-team/rev/e24712ca61f0
Forgot to qref the fixed test: https://hg.mozilla.org/integration/fx-team/rev/dc2496527dd5

This means I need to take the rest of the day off :)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e24712ca61f0
https://hg.mozilla.org/mozilla-central/rev/dc2496527dd5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.