964706 - [prettify] Pretty printer can't handle getter and setter syntax

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

var foo = {
  get bar() {
  }
  set bar(value) {
  }
};

Pretty print this in scratchpad:

var foo = {
  getbar() {
  }
  setbar(value) {
  }
};

:(

Comment 1

[Victor Porof [:vporof][:vp]]

I think it might be a good idea to disable automatically pretty printing "things that look minified" until these errors are sorted out.

Comment 2

[Girish Sharma [:Optimizer]]

(In reply to Victor Porof [:vp] from comment #1)
> I think it might be a good idea to disable automatically pretty printing
> "things that look minified" until these errors are sorted out.

+1 on that.

There are more than 4 different known issues right now ..

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Victor Porof [:vp] from comment #1)
> I think it might be a good idea to disable automatically pretty printing
> "things that look minified" until these errors are sorted out.

All of them except this one are ES6 only, which isn't an issue since ES6 isn't finalized or used in the web at large, so they only affect chrome code.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

And the string escaping, I guess.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: getter-setter.patch

PR on Github: https://github.com/mozilla/pretty-fast/pull/4/files

Try push: https://tbpl.mozilla.org/?tree=Try&rev=3692e5f142db

Comment 6

[Brandon Benvie [:benvie]]

Comment on attachment 8376621 [details] [diff] [review]
getter-setter.patch

Review of attachment 8376621 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/a2692ca4f8da

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a2692ca4f8da