Closed Bug 964791 (fx-update-banners) Opened 10 years ago Closed 10 years ago
Ensure existing Firefox Update Banners still work
There is a special banner that shows a different image based on whether the viewer's browser, if it's Firefox, is up-to-date or not, that was added in bug 719522. The implementation currently uses an .htaccess file generated during the push process based on some settings. The implementation of these banners will probably be updated, but we should still make sure that existing banners in the wild still function correctly.
Summary: Ensure existing Firefox Update Banners still work → Remove apache-based smart banner switching, support existing images
Thanks for this Mike. I think we want to show the "different by design" message. I will write a blog post explaining this change. I assume it will happen at re-launch? Also, I can e-mail those 25 people directly and let them know about the pending change. Sound good?
(In reply to Chelsea Novak [:chelsea] from comment #2) > Thanks for this Mike. I think we want to show the "different by design" > message. Luckily, this appears to be the default behavior if we just remove the code, so yay! > I will write a blog post explaining this change. I assume it will happen at > re-launch? Yes.
This bug is incorporated in the Affiliates 2.0 release currently live in dev: https://affiliates-dev.allizom.org/
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [kb=1255158] → [kb=1255158] [qa-]
I'm removing [qa-] from this because the original purpose of this bug - to make sure that existing update banners still worked with the new site - is still relevant. After input on Chelsea's blog, we decided to not move away from an apache-based upgrade banner system, and were able to support older upgrade banners. This is tricky to test, though, because affiliates-dev has already been migrated. What we'll have to do is have mbrandt or someone create a upgrade banner on affiliates-stage, and keep it around so that when we migrate stage prior to going to prod, he can test to ensure that his old banner code still works (as in, the image still displays correctly based on the user's Firefox version, and clicking the banner still increments the banner click count). Does that sound like a good plan?
Summary: Remove apache-based smart banner switching, support existing images → Ensure existing Firefox Update Banners still work
Whiteboard: [kb=1255158] [qa-] → [kb=1255158]
QA verified on stage (pre-launch) and production (post-launch) -- banners created prior to the redesign persist as well as continue to aggregate click counts.
Status: RESOLVED → VERIFIED
Product: Firefox Affiliates → Firefox Affiliates Graveyard
You need to log in before you can comment on or make changes to this bug.