Closed
Bug 964797
Opened 10 years ago
Closed 10 years ago
Odin ARM: correct the VCVT instructions encoding of the fraction bits
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: dougc, Assigned: dougc)
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
The current encoding of the fraction bits for the VCVT instruction does not agree with the ARM documentation. The 'i' bit is documented to be in bit 5 not bit 6.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → dtc-moz
Attachment #8366653 -
Flags: review?(mrosenberg)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8366653 [details] [diff] [review] Correct the VCVT instructions encoding of the fraction bits Review of attachment 8366653 [details] [diff] [review]: ----------------------------------------------------------------- Oops. Did anything fail, or were you just reading code?
Attachment #8366653 -
Flags: review?(mrosenberg) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thank you for the quick review. There were no failures. Just spotted while adding support for this instruction to the simulator.
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6df2988ebe20
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6df2988ebe20
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•