Odin ARM: correct the VCVT instructions encoding of the fraction bits

RESOLVED FIXED in mozilla29

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dougc, Assigned: dougc)

Tracking

unspecified
mozilla29
ARM
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The current encoding of the fraction bits for the VCVT instruction does not agree with the ARM documentation. The 'i' bit is documented to be in bit 5 not bit 6.
(Assignee)

Comment 1

4 years ago
Created attachment 8366653 [details] [diff] [review]
Correct the VCVT instructions encoding of the fraction bits
Assignee: nobody → dtc-moz
Attachment #8366653 - Flags: review?(mrosenberg)
Comment on attachment 8366653 [details] [diff] [review]
Correct the VCVT instructions encoding of the fraction bits

Review of attachment 8366653 [details] [diff] [review]:
-----------------------------------------------------------------

Oops.  Did anything fail, or were you just reading code?
Attachment #8366653 - Flags: review?(mrosenberg) → review+
(Assignee)

Comment 3

4 years ago
Thank you for the quick review.  There were no failures.  Just spotted while adding support for this instruction to the simulator.
Keywords: checkin-needed

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/6df2988ebe20
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.