Closed Bug 964817 Opened 7 years ago Closed 7 years ago

[Bluetooth] Invoke DBus send operations on I/O thread

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(1 file, 2 obsolete files)

This is a sub-bug for bug 957103. The patches here can be landed separately.
The patch has been taken from bug 957103 and includes all fixes from comment 10, except the final one.
Attachment #8366678 - Flags: review?(echou)
Rebased onto rev 166108:f33daf2f8fb4
Attachment #8366678 - Attachment is obsolete: true
Attachment #8366678 - Flags: review?(echou)
Attachment #8370837 - Flags: review?(echou)
Comment on attachment 8370837 [details] [diff] [review]
[01] Bug 964817: Invoke DBus send operations on I/O thread (v3)

Review of attachment 8370837 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Although the related logic doesn't seem to be changed, please remember to test before land it. Thanks!

::: dom/bluetooth/bluez/linux/BluetoothDBusService.cpp
@@ +2435,3 @@
>                                                       GetConnectedDevicesFilter,
> +                                                     aRunnable);
> +  MOZ_ASSERT(handler);

nit: unnecessary assertion.

@@ +2461,3 @@
>                                                       GetPairedDevicesFilter,
> +                                                     aRunnable);
> +  MOZ_ASSERT(handler);

nit: unnecessary assertion.
Attachment #8370837 - Flags: review?(echou) → review+
Thanks Eric, I'll update and land the patch soon. BTW, I always do basic testing of my patches, even if I only update for rebases. :D
https://hg.mozilla.org/mozilla-central/rev/af1358bae3e3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
Comment on attachment 8371391 [details] [diff] [review]
[01] Bug 964817: Invoke DBus send operations on I/O thread (v4)

Review of attachment 8371391 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluez/linux/BluetoothDBusService.cpp
@@ +2676,5 @@
> +      DBUS_TYPE_STRING, &deviceAddress,
> +      DBUS_TYPE_OBJECT_PATH, &deviceAgentPath,
> +      DBUS_TYPE_STRING, &capabilities,
> +      DBUS_TYPE_INVALID);
> +    NS_ENSURE_SUCCESS_VOID(success);

this is causing the build to fail when BLUEZ configuration is set with the following message,

../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.cpp: In member function 'virtual void CreatePairedDeviceInternalTask::Run()':
../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.cpp:2680:26: error: cannot convert 'bool' to 'nsresult {aka tag_nsresult}' in initialization
Flags: needinfo?(tzimmermann)
Depends on: 952785
(In reply to bhargavg1 from comment #8)
> Comment on attachment 8371391 [details] [diff] [review]
> [01] Bug 964817: Invoke DBus send operations on I/O thread (v4)
> 
> Review of attachment 8371391 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bluetooth/bluez/linux/BluetoothDBusService.cpp
> @@ +2676,5 @@
> > +      DBUS_TYPE_STRING, &deviceAddress,
> > +      DBUS_TYPE_OBJECT_PATH, &deviceAgentPath,
> > +      DBUS_TYPE_STRING, &capabilities,
> > +      DBUS_TYPE_INVALID);
> > +    NS_ENSURE_SUCCESS_VOID(success);
> 
> this is causing the build to fail when BLUEZ configuration is set with the
> following message,
> 
> ../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.
> cpp: In member function 'virtual void CreatePairedDeviceInternalTask::Run()':
> ../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.
> cpp:2680:26: error: cannot convert 'bool' to 'nsresult {aka tag_nsresult}'
> in initialization

Chris has given a patch for this in bug 952785.
> Chris has given a patch for this in bug 952785.

Thanks for the comment. I guess this problem has been fixed. Please ping me if it remains.
Flags: needinfo?(tzimmermann)
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #10)
> > Chris has given a patch for this in bug 952785.
> 
> Thanks for the comment. I guess this problem has been fixed. Please ping me
> if it remains.

Any chances that we are going to check-in the patch. Not sure what the tag [leave open] means. without pulling this patch in the tip build would break, so shouldnt the patch be checked-in to fix the issue
You need to log in before you can comment on or make changes to this bug.