964817 - [Bluetooth] Invoke DBus send operations on I/O thread

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This is a sub-bug for bug 957103. The patches here can be landed separately.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 964817: Invoke DBus send operations on I/O thread (v2)

The patch has been taken from bug 957103 and includes all fixes from comment 10, except the final one.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 964817: Invoke DBus send operations on I/O thread (v3)

Rebased onto rev 166108:f33daf2f8fb4

Comment 3

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8370837 [details] [diff] [review]
[01] Bug 964817: Invoke DBus send operations on I/O thread (v3)

Review of attachment 8370837 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Although the related logic doesn't seem to be changed, please remember to test before land it. Thanks!

::: dom/bluetooth/bluez/linux/BluetoothDBusService.cpp
@@ +2435,3 @@
>                                                       GetConnectedDevicesFilter,
> +                                                     aRunnable);
> +  MOZ_ASSERT(handler);

nit: unnecessary assertion.

@@ +2461,3 @@
>                                                       GetPairedDevicesFilter,
> +                                                     aRunnable);
> +  MOZ_ASSERT(handler);

nit: unnecessary assertion.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Eric, I'll update and land the patch soon. BTW, I always do basic testing of my patches, even if I only update for rebases. :D

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 964817: Invoke DBus send operations on I/O thread (v4)

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://hg.mozilla.org/integration/b2g-inbound/rev/af1358bae3e3

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=af1358bae3e3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af1358bae3e3

Comment 8

[bhargavg1]

Comment on attachment 8371391 [details] [diff] [review]
[01] Bug 964817: Invoke DBus send operations on I/O thread (v4)

Review of attachment 8371391 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluez/linux/BluetoothDBusService.cpp
@@ +2676,5 @@
> +      DBUS_TYPE_STRING, &deviceAddress,
> +      DBUS_TYPE_OBJECT_PATH, &deviceAgentPath,
> +      DBUS_TYPE_STRING, &capabilities,
> +      DBUS_TYPE_INVALID);
> +    NS_ENSURE_SUCCESS_VOID(success);

this is causing the build to fail when BLUEZ configuration is set with the following message,

../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.cpp: In member function 'virtual void CreatePairedDeviceInternalTask::Run()':
../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.cpp:2680:26: error: cannot convert 'bool' to 'nsresult {aka tag_nsresult}' in initialization

Comment 9

[Eric Chou [:ericchou] [:echou]]

(In reply to bhargavg1 from comment #8)
> Comment on attachment 8371391 [details] [diff] [review]
> [01] Bug 964817: Invoke DBus send operations on I/O thread (v4)
> 
> Review of attachment 8371391 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bluetooth/bluez/linux/BluetoothDBusService.cpp
> @@ +2676,5 @@
> > +      DBUS_TYPE_STRING, &deviceAddress,
> > +      DBUS_TYPE_OBJECT_PATH, &deviceAgentPath,
> > +      DBUS_TYPE_STRING, &capabilities,
> > +      DBUS_TYPE_INVALID);
> > +    NS_ENSURE_SUCCESS_VOID(success);
> 
> this is causing the build to fail when BLUEZ configuration is set with the
> following message,
> 
> ../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.
> cpp: In member function 'virtual void CreatePairedDeviceInternalTask::Run()':
> ../../../../../../../../gecko/dom/bluetooth/bluez/linux/BluetoothDBusService.
> cpp:2680:26: error: cannot convert 'bool' to 'nsresult {aka tag_nsresult}'
> in initialization

Chris has given a patch for this in bug 952785.

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

> Chris has given a patch for this in bug 952785.

Thanks for the comment. I guess this problem has been fixed. Please ping me if it remains.

Comment 11

[bhargavg1]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #10)
> > Chris has given a patch for this in bug 952785.
> 
> Thanks for the comment. I guess this problem has been fixed. Please ping me
> if it remains.

Any chances that we are going to check-in the patch. Not sure what the tag [leave open] means. without pulling this patch in the tip build would break, so shouldnt the patch be checked-in to fix the issue