964859 - crash in sqliteInternalCall

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-5380e4ea-87c1-45d6-8f21-c00162140127.
=============================================================

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

I've run into this on my Nexus 5 and Nexus 7 2013. I don't have any STR other than both times I saw this crash I unlocked my device after letting it idle for a while.

Given the stack this looks to be fallout from bug 958706 (as expected).

Comment 2

[Aaron Train [:aaronmt]]

I just hit this on my Nexus 4 (Android 4.4.2) right after a force Sync; new profile.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Refactor SQLite bridge exception handling (v1)

I think the crash happens because errorMsg is not initialized here [1]. Yay goto! This patch refactors exception handling in that file.

[1] http://mxr.mozilla.org/mozilla-central/source/mozglue/android/SQLiteBridge.cpp?rev=ccca3c4247e1#355

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8368213 [details] [diff] [review]
Refactor SQLite bridge exception handling (v1)

Review of attachment 8368213 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on the condition that you fix the db leaks.

::: mozglue/android/SQLiteBridge.cpp
@@ +161,5 @@
>      jenv->ReleaseStringUTFChars(jDb, dbPath);
>      if (rc != SQLITE_OK) {
> +        throwSqliteException(jenv,
> +            "Can't open database: %s", f_sqlite3_errmsg(db));
> +        return nullptr;

Your rework of the logic here is buggy. You need to call sqlite3_close even if open failed, see the sqlite3 documentation.

@@ +199,5 @@
>      jenv->ReleaseStringUTFChars(jDb, dbPath);
>      if (rc != SQLITE_OK) {
> +        throwSqliteException(jenv,
> +            "Can't open database: %s", f_sqlite3_errmsg(db));
> +        return 0;

Same remark, this is buggered and leaks the database handle.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Refactor SQLite bridge exception handling (v1.1)

> r+ on the condition that you fix the db leaks.

Done. Nice catch!

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cdb63b010bb

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1cdb63b010bb