96489 - insertCell method not returning cell object

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Wright]

If inserting a cell in a row between 2 other cells, I don't get the new cell
object returned to the caller.  It looks like the cell is being created in the
correct place because it moves the cells to the right of it.

Comment 1

[David Wright]

Attachment: insertCell() testcase

Comment 2

[David Wright]

as per the attachment:  clicking on the button several times, you can see the
cells moving right, but viewing the javascript console shows why the contents
aren't displayed.

Comment 3

[Sivakiran Tummala]

If index is equal to the number of cells, the new cell is appended.else it is
not working ...

var newcell = therow.insertCell(numcells);  was used replacing
var newcell = therow.insertCell(1);

Comment 4

[Fabian Guisset]

Attachment: Fix bug 96489

Comment 5

[Fabian Guisset]

*mutters something about Wshadow being turned off*
retChild was redeclared in the case the new cell is inserted, but not when it is
appended, which caused this bug. Thanks David for finding it.

Comment 6

[Peter Van der Beken [:peterv]]

r=peterv

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 47659 [details] [diff] [review]
Fix bug 96489

sr=jst

Comment 8

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for 0.9.4

Comment 9

[Fabian Guisset]

Comment on attachment 47659 [details] [diff] [review]
Fix bug 96489

jst, will you be my guest to check this in please? Thanks a lot.

Comment 10

[Johnny Stenback (:jst)]

Will do, thanks for doing all the work, Fabian.

Comment 11

[Johnny Stenback (:jst)]

Fix checked in.

Comment 12

[Sivakiran Tummala]

verified 2001-09-12-05