964929 - prompt user to sign-in again UI

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

We need:
- a notification anchored on the menu panel button that indicates there was an authentication error
- UI in the prefs dialog with a "sign-in" button
- UI in the menu panel to show the error state

Mockups should be in the UI flow diagram.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-964929-Implement-doorhanger-for-sync-errors.patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8367073 [details] [diff] [review]
0001-Bug-964929-Implement-doorhanger-for-sync-errors.patch

Things that are a bit weird:
- the "failed" panel has two buttons (Prefs doesn't seem that useful, but I guess the idea is that it lets you "unlink" i.e. "stop trying to sign-in"?)
- the "success" panel has no button (just mentions "you can configure in prefs" without an easy way to get to it)

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/24ddba64280c

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Pushed a follow-up to remove OSX-only button styles from Windows and Linux. This will need to be fixed and checked afterwards.

https://hg.mozilla.org/integration/fx-team/rev/044aec58f5b3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/24ddba64280c
https://hg.mozilla.org/mozilla-central/rev/044aec58f5b3

Comment 6

[Tracy Walker [:tracy]]

Verified with latest builds of Nightly and Aurora