96499 - account central / get msg problem if server is closed

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

account central / get msg problem if server is closed

select a server, close it in the folder pane.

in account central, do "read mail".

we should be expanding and selecting the inbox.  we aren't, it's a regression
caused by the folder outliner landing.

fix in my tree, here comes the patch.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 2

[racham]

Seth,

This patch didn't work for me.

js console error :

Error opening inbox for server -> [Exception... "Component returned failure code
: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x800040
02 (NS_NOINTERFACE)"  location: "JS frame :: chrome://messenger/content/msgMail3
PaneWindow.js :: EnsureAllAncestorsAreExpanded :: line 999"  data: no]

Here is what fixed it :

in mailwindow.js :

besides your patch, just do,

SelectFolder(inboxFolder.URI);

instead of 

SelectFolder(folderOutliner, folderResource)

then we can get rid of

        var folderResource = RDF.GetResource(inboxFolder.URI)
        var folderOutliner = GetFolderOutliner();
also.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

yes, that patch was bad.  updated with a patch that works.

Comment 5

[racham]

Attachment: patch after the fix I mentioned

Comment 6

[racham]

Cool..you beat me :-) 
r=bhuvan.

Comment 7

[(not reading, please use [e-mail] instead)]

there's more.

if you don't check mail on startup, we aren't selecting the account manager.  
(this might be a known problem.)

I get to the console:

"TypeError: folder.parent has no propertiesException in LoadStartFolder caused 
by no default account.  We know about this"

I don't think that still applies.  I'll work on a fix for that.

Comment 8

[racham]

That sounds like a separate problem to me (server folder selection not
effective). But it is OK with me to use this bug to resolve that one as well.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: new patch, fixes start up not selecting account central problem.

Comment 10

[racham]

Looking at the code, I was also thinking that problem seems to be arising as 
we are trying to access the parent of the folder when we already reached the end 
 in the ancestor levels.

Your patch takes care of that and more. It works fine.

r=bhuvan.

Comment 11

[(not reading, please use [e-mail] instead)]

I'm getting a bunch of dups on some of these problems.

I'll go beg drivers so I can check that last patch in.

Comment 12

[David :Bienvenu]

sr=bienvenu

Comment 13

[Asa Dotzler [:asa]]

a=asa on behalf of [e-mail]

Comment 14

[(not reading, please use [e-mail] instead)]

fixed.

Comment 15

[Sheela Ravindran]

verified 
2001-09-04-10 win98
2001-09-04-08 mac, linux