965053 - [B2G][Everything.me] Many apps do not show that they have already been added to the Homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Matthew Vaughan]

Attachment: Video of issue occurring with Facebook app.

Description:
Many of the apps that the user can add to the Homescreen from Everything.me do not tell the user if they have already been added to the Homescreen. There are some other apps that do tell the user however, which creates an inconsistency for alerts.

Repro Steps:
1) Updat Buri to BuildID: 20140128040224
2) Navigate to the 'Social' Smart Collection
3) Long tap Facebook (or Google+, Tumblr, Flickr, etc.)
4) Select "Save to Homescreen"
5) Repeat steps 3 & 4 once using same app

Actual:
Alert is not given to the user that the chosen app has already been added to the Homescreen.

Expected:
User is given an alert that the chosen app has already been added to the Homescreen (Twitter is one app that WILL alert the user it has already been installed).

Environmental Variables:
Device: Buri Master (1.4) MOZ RIL
BuildID: 20140128040224
Gaia: 6586d2b8b43c6997be5cf5895bbdf3dd20490725
Gecko: 4da3e21a0e5f
Version: 29.0a1
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 5/5
See attached: AlreadyAddedAlert.mpeg

This issue reproduces on the 01/28/14 Master (1.4).
This issue does not reproduce on the 01/28/14 1.2.

Comment 1

[Jason Smith [:jsmith]]

Saw this myself - the UX here is highly inconsistent.

Comment 2

[Jason Smith [:jsmith]]

The regression however feels minor - the user is getting awareness that the task is complete & knows something is present of the homescreen. The only confusion here is the way it's messaged.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

We forgot to add this code when we fixed the collision between apps and bookmars :)

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8367174 [details]
Patch v1

Great! Nice catch.

Comment 5

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/65f6b1ad6da0760cd946fada0fdcdf2ef4eaa0d9

Comment 6

[Marcelino Veiga Tuimil [:sonmarce]]

According to status flags, I think we should ask to be a blocker for 1.3

Comment 7

[Preeti Raghunath(:Preeti)]

Unblocking for 1.3